third_party/WebKit/Source/core/html/HTMLInputElement.h - Issue 1420693006: Introduce a struct to store arguments of Element::focus().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 1420693006: Introduce a struct to store arguments of Element::focus(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAreaElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h

index b79b6eb9d71e4c2ce8bdfb9509daf9b55d865aec..fec9689cdcb6ed7f3fae55ae7176015952e5a410 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h

@@ -150,7 +150,7 @@ public:

bool layoutObjectIsNeeded(const ComputedStyle&) final;

LayoutObject* createLayoutObject(const ComputedStyle&) override;

void detach(const AttachContext& = AttachContext()) final;

- void updateFocusAppearance(bool restorePreviousSelection) final;

+ void updateFocusAppearance(SelectionBehaviorOnFocus) final;

// FIXME: For isActivatedSubmit and setActivatedSubmit, we should use the NVI-idiom here by making

// it private virtual in all classes and expose a public method in HTMLFormControlElement to call