third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 1420693006: Introduce a struct to store arguments of Element::focus().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1420693006: Introduce a struct to store arguments of Element::focus(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index de86ef8dc7b8df709d7782449d8c0b03622c2b3c..a710e85d749f8a9063143a5654302b20a0d59566 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -421,7 +421,7 @@ void WebFrameWidgetImpl::setFocus(bool enable)

// focused, then the focus element shows with a focus ring but

// no caret and does respond to keyboard inputs.

if (element->isTextFormControl()) {

- element->updateFocusAppearance(true);

+ element->updateFocusAppearance(SelectionBehaviorOnFocus::Restore);

} else if (element->isContentEditable()) {

// updateFocusAppearance() selects all the text of

// contentseditable DIVs. So we set the selection explicitly

« no previous file with comments | « third_party/WebKit/Source/core/page/FocusController.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »