Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1419123002: android: move overscroll effects to ui/ (Closed)

Created:
5 years, 2 months ago by no sievers
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: move overscroll effects to ui/ Instead of shoving this into content, move this down. This separates this out nicer from the Aura+Android build which doesn't fulfill all the dependencies. The code here mainly depends on cc. BUG=507792 NOTRY=True Committed: https://crrev.com/a964cb746a2b7031188199d6cb7d5459868d9c7b Cr-Commit-Position: refs/heads/master@{#355829}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : animation_utils.h gyp/Gn #

Patch Set 5 : missing file #

Patch Set 6 : fix exports for component build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -1912 lines) Patch
D content/browser/android/animation_utils.h View 1 chunk +0 lines, -33 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
D content/browser/android/edge_effect.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/browser/android/edge_effect.cc View 1 chunk +0 lines, -360 lines 0 comments Download
D content/browser/android/edge_effect_base.h View 1 chunk +0 lines, -67 lines 0 comments Download
D content/browser/android/edge_effect_base.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/android/edge_effect_l.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/browser/android/edge_effect_l.cc View 1 chunk +0 lines, -301 lines 0 comments Download
M content/browser/android/overscroll_controller_android.h View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/android/overscroll_controller_android.cc View 1 chunk +10 lines, -2 lines 0 comments Download
D content/browser/android/overscroll_glow.h View 1 chunk +0 lines, -110 lines 0 comments Download
D content/browser/android/overscroll_glow.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D content/browser/android/overscroll_refresh.h View 1 chunk +0 lines, -104 lines 0 comments Download
D content/browser/android/overscroll_refresh.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D content/browser/android/overscroll_refresh_unittest.cc View 1 chunk +0 lines, -241 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 3 chunks +0 lines, -11 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/BUILD.gn View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M ui/android/DEPS View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
A + ui/android/animation_utils.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/android/edge_effect.h View 1 2 3 4 5 3 chunks +9 lines, -7 lines 0 comments Download
A + ui/android/edge_effect.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/android/edge_effect_base.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/android/edge_effect_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/android/edge_effect_l.h View 1 2 3 4 5 3 chunks +9 lines, -7 lines 0 comments Download
A + ui/android/edge_effect_l.cc View 3 chunks +7 lines, -6 lines 0 comments Download
A + ui/android/overscroll_glow.h View 1 2 3 4 5 4 chunks +10 lines, -8 lines 0 comments Download
A + ui/android/overscroll_glow.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/android/overscroll_refresh.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/android/overscroll_refresh.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/android/overscroll_refresh_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/android/ui_android.gyp View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M ui/android/window_android_compositor.h View 3 chunks +5 lines, -1 line 0 comments Download
A ui/android/window_android_compositor.cc View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
no sievers
+Dana for ui/android/DEPS
5 years, 2 months ago (2015-10-23 00:15:23 UTC) #4
aurimas (slooooooooow)
LGTM. The move seems reasonable especially given there are no other dependencies
5 years, 2 months ago (2015-10-23 00:16:06 UTC) #6
danakj
LGTM
5 years, 2 months ago (2015-10-23 00:52:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419123002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419123002/80001
5 years, 2 months ago (2015-10-23 15:55:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112214)
5 years, 2 months ago (2015-10-23 16:03:10 UTC) #15
David Trainor- moved to gerrit
lgtm
5 years, 2 months ago (2015-10-23 16:33:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419123002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419123002/100001
5 years, 2 months ago (2015-10-23 16:49:20 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/125032)
5 years, 2 months ago (2015-10-23 17:54:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419123002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419123002/100001
5 years, 2 months ago (2015-10-23 17:56:38 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-23 18:06:46 UTC) #26
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/a964cb746a2b7031188199d6cb7d5459868d9c7b Cr-Commit-Position: refs/heads/master@{#355829}
5 years, 2 months ago (2015-10-23 18:07:47 UTC) #27
jdduke (slow)
Yay :) I tried to minimize any explicit content/ dependencies when writing this code, hopefully ...
5 years, 2 months ago (2015-10-23 18:12:16 UTC) #28
no sievers
5 years, 2 months ago (2015-10-23 18:14:57 UTC) #29
Message was sent while issue was closed.
On 2015/10/23 18:12:16, jdduke wrote:
> Yay :) I tried to minimize any explicit content/ dependencies when writing
this
> code, hopefully it wasn't super painful...

Ended up being simple, since it only depended on compositor for which we already
had the ui::WindowAndroidCompositor interface now.

Powered by Google App Engine
This is Rietveld 408576698