update elements and fix some bugs

update elements and fix some bugs

R=sigmund@google.com

Committed: https://github.com/dart-lang/polymer-elements/commit/490b24063cd642e965693f0dfd559d3192129fe9

[jakemac, 2015-10-28 21:30:49]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-10-28 22:35:17]

lgtm

https://codereview.chromium.org/1418513006/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1418513006/diff/20001/CHANGELOG.md#newcode3
CHANGELOG.md:3: Update the elements and resolve multiple outstanding issues.
would you like to include details on what issues?

https://codereview.chromium.org/1418513006/diff/20001/test/firebase_collectio...
File test/firebase_collection_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/firebase_collectio...
test/firebase_collection_test.dart:104: firebase.jsElement.callMethod('push',
['data', intendedValue]) - 1;
should `push` be exposed in the Dart API? Is it part of the FirebaseCollection
API? or something we planned to translate as `add`, but there is already another
use for `add`?

https://codereview.chromium.org/1418513006/diff/20001/test/firebase_collectio...
test/firebase_collection_test.dart:184: var key =
context['Polymer']['Collection']
do we want to eventually wrap these static APIs as well? Maybe when the cleaner
JS interop ships?

https://codereview.chromium.org/1418513006/diff/20001/test/iron_collapse_test...
File test/iron_collapse_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/iron_collapse_test...
test/iron_collapse_test.dart:79: await wait(delay);
much better :)

https://codereview.chromium.org/1418513006/diff/20001/test/iron_selector_excl...
File test/iron_selector_exclude_local_names_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/iron_selector_excl...
test/iron_selector_exclude_local_names_test.dart:25:
expect(test1.jsElement['_excludedLocalNames']['template'], isNotNull);
is this just private internal state or something users were expected to
configure externally?

https://codereview.chromium.org/1418513006/diff/20001/test/paper_checked_elem...
File test/paper_checked_element_behavior_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/paper_checked_elem...
test/paper_checked_element_behavior_test.dart:54: test('element ripple has
checked attribute when element tapped to check', () {
long line (below too)

[jakemac, 2015-10-29 16:07:29]

https://codereview.chromium.org/1418513006/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1418513006/diff/20001/CHANGELOG.md#newcode3
CHANGELOG.md:3: Update the elements and resolve multiple outstanding issues.
On 2015/10/28 22:35:17, Siggi Cherem (dart-lang) wrote:
> would you like to include details on what issues?

There were a lot of small issues with types and other things that just got fixed
with the roll. I don't know that listing them all has a lot of value (presumably
anybody who was blocked on an issue was following it on github)?

https://codereview.chromium.org/1418513006/diff/20001/test/firebase_collectio...
File test/firebase_collection_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/firebase_collectio...
test/firebase_collection_test.dart:104: firebase.jsElement.callMethod('push',
['data', intendedValue]) - 1;
On 2015/10/28 22:35:16, Siggi Cherem (dart-lang) wrote:
> should `push` be exposed in the Dart API? Is it part of the FirebaseCollection
> API? or something we planned to translate as `add`, but there is already
another
> use for `add`?

I guess what should really happen here is changing the `add` method on the
firebase element to have a different name. The `removeItem` method is the same
way. I will rename them `firebaseAdd` and `firebaseRemove`?

https://codereview.chromium.org/1418513006/diff/20001/test/firebase_collectio...
test/firebase_collection_test.dart:184: var key =
context['Polymer']['Collection']
On 2015/10/28 22:35:16, Siggi Cherem (dart-lang) wrote:
> do we want to eventually wrap these static APIs as well? Maybe when the
cleaner
> JS interop ships?

These collection apis are not really useful in general I don't think except
internally to polymer. If somebody asks for them we can wrap them.

https://codereview.chromium.org/1418513006/diff/20001/test/iron_collapse_test...
File test/iron_collapse_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/iron_collapse_test...
test/iron_collapse_test.dart:79: await wait(delay);
On 2015/10/28 22:35:16, Siggi Cherem (dart-lang) wrote:
> much better :)

Acknowledged.

https://codereview.chromium.org/1418513006/diff/20001/test/iron_selector_excl...
File test/iron_selector_exclude_local_names_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/iron_selector_excl...
test/iron_selector_exclude_local_names_test.dart:25:
expect(test1.jsElement['_excludedLocalNames']['template'], isNotNull);
On 2015/10/28 22:35:16, Siggi Cherem (dart-lang) wrote:
> is this just private internal state or something users were expected to
> configure externally?

This got moved to be a private variable. I guess technically that's a breaking
change, but I doubt this was being used and since we are in RC still I think its
fine not to bump the version.

https://codereview.chromium.org/1418513006/diff/20001/test/paper_checked_elem...
File test/paper_checked_element_behavior_test.dart (right):

https://codereview.chromium.org/1418513006/diff/20001/test/paper_checked_elem...
test/paper_checked_element_behavior_test.dart:54: test('element ripple has
checked attribute when element tapped to check', () {
On 2015/10/28 22:35:16, Siggi Cherem (dart-lang) wrote:
> long line (below too)

Done.

[jakemac, 2015-10-30 20:41:15]

Committed patchset #4 (id:30001) manually as
490b24063cd642e965693f0dfd559d3192129fe9 (presubmit successful).