Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: test/paper_ripple_test.dart

Issue 1418513006: update elements and fix some bugs (Closed) Base URL: git@github.com:dart-lang/polymer_elements.git@master
Patch Set: code review updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/paper_ripple_behavior_test.html ('k') | test/paper_ripple_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/paper_ripple_test.dart
diff --git a/test/paper_ripple_test.dart b/test/paper_ripple_test.dart
index 291d7171601eed1e311297ed6511e1f283360b2d..03707e60ce49ca8c04f5d752f61edfe137a05807 100644
--- a/test/paper_ripple_test.dart
+++ b/test/paper_ripple_test.dart
@@ -4,7 +4,7 @@
@TestOn('browser')
library polymer_elements.test.paper_ripple_test;
-import 'dart:html';
+import 'dart:html' hide Point;
import 'package:polymer_elements/paper_ripple.dart';
import 'package:test/test.dart';
import 'package:web_components/web_components.dart';
@@ -22,29 +22,67 @@ main() async {
setUp(() {
rippleContainer = fixture('TrivialRipple');
ripple = rippleContainer.children.first;
- mouseEvent = fakeMouseEvent(ripple, 10, 10);
});
test('creates a ripple', () {
expect(ripple.ripples.length, 0);
- ripple.downAction(mouseEvent);
+ down(ripple);
expect(ripple.ripples.length, 1);
});
test('may create multiple ripples that overlap', () {
expect(ripple.ripples.length, 0);
for (var i = 0; i < 3; ++i) {
- ripple.downAction(mouseEvent);
+ down(ripple);
expect(ripple.ripples.length, i + 1);
}
});
});
+
+ group('when holdDown is togggled', () {
+ setUp( () {
+ rippleContainer = fixture('TrivialRipple');
+ ripple = rippleContainer.children.first;
+ });
+
+ test('generates a ripple', () {
+ ripple.holdDown = true;
+ expect(ripple.ripples.length, 1);
+ });
+
+ test('generates a ripple when noink', () {
+ ripple.noink = true;
+ ripple.holdDown = true;
+ expect(ripple.ripples.length, 1);
+
+ });
+
+ });
+
+ group('when target is noink', () {
+ setUp( () {
+ rippleContainer = fixture('NoinkTarget');
+ ripple = rippleContainer.children.first;
+ });
+
+ test('tapping does not create a ripple', () {
+ expect(ripple.keyEventTarget, ripple);
+ expect(ripple.ripples.length, 0);
+ down(ripple);
+ expect(ripple.ripples.length, 0);
+ });
+
+ test('ripples can be manually created', () {
+ expect(ripple.ripples.length, 0);
+ ripple.simulatedRipple();
+ expect(ripple.ripples.length, 1);
+ });
+ });
group('with the `center` attribute set to true', () {
setUp(() {
rippleContainer = fixture('CenteringRipple');
ripple = rippleContainer.children.first;
- mouseEvent = fakeMouseEvent(ripple, 10, 10);
});
test('ripples will center', () {
@@ -52,9 +90,9 @@ main() async {
// let's ask the browser what `translate3d(0px, 0px, 0)` will actually look like
var div = document.createElement('div');
div.style.transform = 'translate3d(0px, 0px, 0)';
- ripple.downAction(mouseEvent);
+ down(ripple);
waveContainerElement = ripple.ripples[0]['waveContainer'];
- ripple.upAction(mouseEvent);
+ up(ripple);
return requestAnimationFrame().then((_) {
var currentTransform = waveContainerElement.style.transform;
expect(div.style.transform, isNotNull);
@@ -74,10 +112,10 @@ main() async {
test('ripples will gravitate towards the center', () {
var waveContainerElement;
var waveTranslateString;
- ripple.downAction(mouseEvent);
+ down(ripple, new Point(10, 10));
waveContainerElement = ripple.ripples[0]['waveContainer'];
waveTranslateString = waveContainerElement.style.transform;
- ripple.upAction(mouseEvent);
+ up(ripple);
return requestAnimationFrame().then((_) {
expect(waveTranslateString, isNotNull);
expect(waveContainerElement.style.transform, isNotNull);
« no previous file with comments | « test/paper_ripple_behavior_test.html ('k') | test/paper_ripple_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698