Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: lib/src/iron-overlay-behavior/test/iron-overlay-behavior.html

Issue 1418513006: update elements and fix some bugs (Closed) Base URL: git@github.com:dart-lang/polymer_elements.git@master
Patch Set: code review updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/iron-overlay-behavior/test/iron-overlay-behavior.html
diff --git a/lib/src/iron-overlay-behavior/test/iron-overlay-behavior.html b/lib/src/iron-overlay-behavior/test/iron-overlay-behavior.html
index f821e5589945a7f8b31a3bac0ed4c2128e38773f..a352a4b18948fc2116b9978176cbd9339f7bfefa 100644
--- a/lib/src/iron-overlay-behavior/test/iron-overlay-behavior.html
+++ b/lib/src/iron-overlay-behavior/test/iron-overlay-behavior.html
@@ -86,7 +86,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
function runAfterOpen(overlay, cb) {
overlay.addEventListener('iron-overlay-opened', function() {
- cb();
+ Polymer.Base.async(cb, 1);
});
overlay.open();
}
@@ -181,6 +181,15 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
test('cancel an overlay by clicking outside', function(done) {
runAfterOpen(overlay, function() {
+ overlay.addEventListener('iron-overlay-canceled', function(event) {
+ done();
+ });
+ Polymer.Base.fire.call(document, 'click');
+ });
+ });
+
+ test('close an overlay by clicking outside', function(done) {
+ runAfterOpen(overlay, function() {
overlay.addEventListener('iron-overlay-closed', function(event) {
assert.isTrue(event.detail.canceled, 'overlay is canceled');
done();
@@ -189,8 +198,36 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
});
});
+ test('cancel event can be prevented', function(done) {
+ runAfterOpen(overlay, function() {
+ overlay.addEventListener('iron-overlay-canceled', function(event) {
+ event.preventDefault();
+ });
+ var closedListener = function(event) {
+ throw new Error('iron-overlay-closed should not fire');
+ };
+ overlay.addEventListener('iron-overlay-closed', closedListener);
+ Polymer.Base.fire.call(document, 'click');
+ setTimeout(function() {
+ overlay.removeEventListener('iron-overlay-closed', closedListener);
+ done();
+ }, 10);
+ });
+ });
+
test('cancel an overlay with esc key', function(done) {
runAfterOpen(overlay, function() {
+ overlay.addEventListener('iron-overlay-canceled', function(event) {
+ done();
+ });
+ fireEvent('keydown', {
+ keyCode: 27
+ }, document);
+ });
+ });
+
+ test('close an overlay with esc key', function(done) {
+ runAfterOpen(overlay, function() {
overlay.addEventListener('iron-overlay-closed', function(event) {
assert.isTrue(event.detail.canceled, 'overlay is canceled');
done();
« no previous file with comments | « lib/src/iron-overlay-behavior/iron-overlay-behavior.html ('k') | lib/src/iron-range-behavior/iron-range-behavior.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698