Allow max tile size to be overridden separately from max texture size.

Allow max tile size to be overridden separately from max texture size.

This allows internal Gr texture creation code to succeed for extraneous textures while running the bleed GM. This means we can turn on the shader variants.

Committed: https://skia.googlesource.com/skia/+/8c07b7ab53b93b39015a409a4e0a9174feb6a4c3

[bsalomon, 2015-11-02 18:22:59]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-11-02 18:23:02]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-11-02 18:23:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418473004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418473004/1

[commit-bot: I haz the power, 2015-11-02 18:23:11]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-11-03 00:23 UTC

[robertphillips, 2015-11-02 18:37:40]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2015-11-02 18:37:57]

lgtm + questions & a typo

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrCaps.h
File include/gpu/GrCaps.h (right):

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrCaps.h#newcod...
include/gpu/GrCaps.h:191: int maxTextureSize() const { return fMaxTextureSize; }
/** This is the threshold used by GPU devices to decide if a sw-backed
image/bitmap is too large to be rendered as a single texture. It should always
be strictly less than or equal to the max texture size */

Should we rename it tileThreshold, tilingThreshold ?

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrContextOptions.h
File include/gpu/GrContextOptions.h (right):

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrContextOption...
include/gpu/GrContextOptions.h:36: int  fMaxTextureSizeOverride;
maximum ?

https://codereview.chromium.org/1418473004/diff/1/src/gpu/GrCaps.cpp
File src/gpu/GrCaps.cpp (right):

https://codereview.chromium.org/1418473004/diff/1/src/gpu/GrCaps.cpp#newcode127
src/gpu/GrCaps.cpp:127: } else {
Should we power of two this?

[bsalomon, 2015-11-02 19:06:49]

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrCaps.h
File include/gpu/GrCaps.h (right):

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrCaps.h#newcod...
include/gpu/GrCaps.h:191: int maxTextureSize() const { return fMaxTextureSize; }
On 2015/11/02 18:37:57, robertphillips wrote:
> /** This is the threshold used by GPU devices to decide if a sw-backed
> image/bitmap is too large to be rendered as a single texture. It should always
> be strictly less than or equal to the max texture size */
> 
> Should we rename it tileThreshold, tilingThreshold ?

I don't think so... there are lots of tile thresholds... we tile things below
this size based on fraction used, etc. It really is the maximum tile size.

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrContextOptions.h
File include/gpu/GrContextOptions.h (right):

https://codereview.chromium.org/1418473004/diff/1/include/gpu/GrContextOption...
include/gpu/GrContextOptions.h:36: int  fMaxTextureSizeOverride;
On 2015/11/02 18:37:57, robertphillips wrote:
> maximum ?

Done.

https://codereview.chromium.org/1418473004/diff/1/src/gpu/GrCaps.cpp
File src/gpu/GrCaps.cpp (right):

https://codereview.chromium.org/1418473004/diff/1/src/gpu/GrCaps.cpp#newcode127
src/gpu/GrCaps.cpp:127: } else {
On 2015/11/02 18:37:57, robertphillips wrote:
> Should we power of two this?

why?

[bsalomon, 2015-11-02 19:21:40]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-11-02 19:21:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1418473004/#ps20001
(title: "fix comment spelling")

[commit-bot: I haz the power, 2015-11-02 19:21:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418473004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418473004/20001

[commit-bot: I haz the power, 2015-11-02 19:36:54]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8c07b7ab53b93b39015a409a4e0a9174feb6a4c3