Add bleed GM variants for bmp backed by an oversized texture

Add bleed GM variants for bmp backed by an oversized texture

Committed: https://skia.googlesource.com/skia/+/9c58654fa27d85f51f54e904fbfa4e250921c261

[bsalomon, 2015-11-02 19:25:48]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-11-02 19:37:59]

lgtm + stuff

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp
File gm/bleed.cpp (right):

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode32
gm/bleed.cpp:32: 
// Upload the tight-fitting sw-backed bitmap to a loose-fitting gpu-backed
texture before drawing 

?

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode42
gm/bleed.cpp:42: }
mv textureBmp to right before the GrWrapTextureInBitmap call ?

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode49
gm/bleed.cpp:49: desc.fWidth = bitmap.width() + 16;
22 ?

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode55
gm/bleed.cpp:55: SkAutoLockPixels al(bitmap);
Can we clear the texture to green first ?

[bsalomon, 2015-11-02 20:17:31]

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp
File gm/bleed.cpp (right):

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode32
gm/bleed.cpp:32: 
On 2015/11/02 19:37:59, robertphillips wrote:
> // Upload the tight-fitting sw-backed bitmap to a loose-fitting gpu-backed
> texture before drawing 
> 
> ?

Done.

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode42
gm/bleed.cpp:42: }
On 2015/11/02 19:37:59, robertphillips wrote:
> mv textureBmp to right before the GrWrapTextureInBitmap call ?

Done.

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode49
gm/bleed.cpp:49: desc.fWidth = bitmap.width() + 16;
On 2015/11/02 19:37:59, robertphillips wrote:
> 22 ?

Just wanted a weird number... Added comment.

https://codereview.chromium.org/1426253002/diff/40001/gm/bleed.cpp#newcode55
gm/bleed.cpp:55: SkAutoLockPixels al(bitmap);
On 2015/11/02 19:37:59, robertphillips wrote:
> Can we clear the texture to green first ?

Done.

[bsalomon, 2015-11-02 20:17:34]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-11-02 20:17:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1426253002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2015-11-02 20:17:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426253002/60001

[commit-bot: I haz the power, 2015-11-02 20:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 20:18:37]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bsalomon, 2015-11-02 20:22:39]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-11-02 20:22:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1426253002/#ps80001
(title: "fix no gpu build?")

[commit-bot: I haz the power, 2015-11-02 20:22:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426253002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426253002/80001

[commit-bot: I haz the power, 2015-11-02 20:33:24]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/9c58654fa27d85f51f54e904fbfa4e250921c261