Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Issue 1418133011: Remove the named item getters on TextTrackList and TextTrackCueList (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years, 1 month ago
Reviewers:
fs, timvolodine
CC:
fs, android-webview-reviews_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Inactive, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the named item getters on TextTrackList and TextTrackCueList Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fuNdIeOnmTo/kT-R9dnFDAAJ BUG=535475 R=fs@opera.com Committed: https://crrev.com/02ef66b244764acf726b8a4b6f8ce07f18852470 Cr-Commit-Position: refs/heads/master@{#356809}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -28 lines) Patch
M android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCueList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCueList.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418133011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418133011/1
5 years, 1 month ago (2015-10-26 12:52:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 14:07:18 UTC) #4
philipj_slow
PTAL
5 years, 1 month ago (2015-10-27 09:09:08 UTC) #6
fs
lgtm
5 years, 1 month ago (2015-10-27 09:16:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418133011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418133011/1
5 years, 1 month ago (2015-10-27 09:19:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112957)
5 years, 1 month ago (2015-10-27 09:23:54 UTC) #11
philipj_slow
timvolodine@, can you review android_webview?
5 years, 1 month ago (2015-10-27 14:57:54 UTC) #13
timvolodine
android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt -- LGTM thanks!
5 years, 1 month ago (2015-10-27 15:02:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418133011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418133011/1
5 years, 1 month ago (2015-10-27 15:37:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/86419) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-10-27 15:40:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418133011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418133011/20001
5 years, 1 month ago (2015-10-29 09:25:05 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 10:43:29 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 10:44:28 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02ef66b244764acf726b8a4b6f8ce07f18852470
Cr-Commit-Position: refs/heads/master@{#356809}

Powered by Google App Engine
This is Rietveld 408576698