Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: third_party/WebKit/Source/core/html/track/TextTrackCueList.h

Issue 1418133011: Remove the named item getters on TextTrackList and TextTrackCueList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 26 matching lines...) Expand all
37 class TextTrackCueList final : public GarbageCollected<TextTrackCueList>, public ScriptWrappable { 37 class TextTrackCueList final : public GarbageCollected<TextTrackCueList>, public ScriptWrappable {
38 DEFINE_WRAPPERTYPEINFO(); 38 DEFINE_WRAPPERTYPEINFO();
39 public: 39 public:
40 static TextTrackCueList* create() 40 static TextTrackCueList* create()
41 { 41 {
42 return new TextTrackCueList; 42 return new TextTrackCueList;
43 } 43 }
44 44
45 unsigned long length() const; 45 unsigned long length() const;
46 46
47 TextTrackCue* item(unsigned index) const; 47 TextTrackCue* anonymousIndexedGetter(unsigned index) const;
48 TextTrackCue* getCueById(const AtomicString&) const; 48 TextTrackCue* getCueById(const AtomicString&) const;
49 49
50 bool add(TextTrackCue*); 50 bool add(TextTrackCue*);
51 bool remove(TextTrackCue*); 51 bool remove(TextTrackCue*);
52 52
53 void collectActiveCues(TextTrackCueList&) const; 53 void collectActiveCues(TextTrackCueList&) const;
54 void updateCueIndex(TextTrackCue*); 54 void updateCueIndex(TextTrackCue*);
55 bool isCueIndexValid(unsigned probeIndex) const { return probeIndex < m_firs tInvalidIndex; } 55 bool isCueIndexValid(unsigned probeIndex) const { return probeIndex < m_firs tInvalidIndex; }
56 void validateCueIndexes(); 56 void validateCueIndexes();
57 57
58 DECLARE_TRACE(); 58 DECLARE_TRACE();
59 59
60 private: 60 private:
61 TextTrackCueList(); 61 TextTrackCueList();
62 size_t findInsertionIndex(const TextTrackCue*) const; 62 size_t findInsertionIndex(const TextTrackCue*) const;
63 void invalidateCueIndex(size_t index); 63 void invalidateCueIndex(size_t index);
64 void clear(); 64 void clear();
65 65
66 HeapVector<Member<TextTrackCue>> m_list; 66 HeapVector<Member<TextTrackCue>> m_list;
67 size_t m_firstInvalidIndex; 67 size_t m_firstInvalidIndex;
68 }; 68 };
69 69
70 } // namespace blink 70 } // namespace blink
71 71
72 #endif // TextTrackCueList_h 72 #endif // TextTrackCueList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698