third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 1418133011: Remove the named item getters on TextTrackList and TextTrackCueList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1418133011: Remove the named item getters on TextTrackList and TextTrackCueList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index f1334c3da09a4fd48e046b02ace7b7001c81cc40..de7d65b0cafdf89cbe17223d38e0b481675872d8 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -823,7 +823,7 @@ void HTMLMediaElement::loadInternal()

m_textTracksWhenResourceSelectionBegan.clear();

if (m_textTracks) {

for (unsigned i = 0; i < m_textTracks->length(); ++i) {

- TextTrack* track = m_textTracks->item(i);

+ TextTrack* track = m_textTracks->anonymousIndexedGetter(i);

if (track->mode() != TextTrack::disabledKeyword())

m_textTracksWhenResourceSelectionBegan.append(track);

}

@@ -3166,11 +3166,12 @@ bool HTMLMediaElement::hasClosedCaptions() const

{

if (m_textTracks) {

for (unsigned i = 0; i < m_textTracks->length(); ++i) {

- if (m_textTracks->item(i)->readinessState() == TextTrack::FailedToLoad)

+ TextTrack* track = m_textTracks->anonymousIndexedGetter(i);

+ if (track->readinessState() == TextTrack::FailedToLoad)

continue;

- if (m_textTracks->item(i)->kind() == TextTrack::captionsKeyword()

- || m_textTracks->item(i)->kind() == TextTrack::subtitlesKeyword())

+ if (track->kind() == TextTrack::captionsKeyword()

+ || track->kind() == TextTrack::subtitlesKeyword())

return true;

}

@@ -3295,7 +3296,7 @@ void HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured()

// non-default tracks should be displayed based on language preferences if

// the user has turned captions on).

for (unsigned i = 0; i < m_textTracks->length(); ++i) {

- TextTrack* textTrack = m_textTracks->item(i);

+ TextTrack* textTrack = m_textTracks->anonymousIndexedGetter(i);

String kind = textTrack->kind();

if (kind == TextTrack::subtitlesKeyword() || kind == TextTrack::captionsKeyword())