Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrackList.cpp

Issue 1418133011: Remove the named item getters on TextTrackList and TextTrackCueList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TextTrackList.cpp
diff --git a/third_party/WebKit/Source/core/html/track/TextTrackList.cpp b/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
index dd159263ce6d3b242106753b202b7d0c10b61df6..1cd12b4f7edc68c8de7724c883f0b64ce438599b 100644
--- a/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
+++ b/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
@@ -112,7 +112,7 @@ int TextTrackList::getTrackIndexRelativeToRenderedTracks(TextTrack *textTrack)
return -1;
}
-TextTrack* TextTrackList::item(unsigned index)
+TextTrack* TextTrackList::anonymousIndexedGetter(unsigned index)
{
// 4.8.10.12.1 Text track model
// The text tracks are sorted as follows:
@@ -142,7 +142,7 @@ TextTrack* TextTrackList::getTrackById(const AtomicString& id)
// TextTrackList object whose id IDL attribute would return a value equal
// to the value of the id argument.
for (unsigned i = 0; i < length(); ++i) {
- TextTrack* track = item(i);
+ TextTrack* track = anonymousIndexedGetter(i);
if (track->id() == id)
return track;
}
@@ -316,7 +316,7 @@ void TextTrackList::scheduleRemoveTrackEvent(TextTrack* track)
bool TextTrackList::hasShowingTracks()
{
for (unsigned i = 0; i < length(); ++i) {
- if (item(i)->mode() == TextTrack::showingKeyword())
+ if (anonymousIndexedGetter(i)->mode() == TextTrack::showingKeyword())
return true;
}
return false;
« no previous file with comments | « third_party/WebKit/Source/core/html/track/TextTrackList.h ('k') | third_party/WebKit/Source/core/html/track/TextTrackList.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698