Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/core/html/track/TextTrack.cpp

Issue 1418133011: Remove the named item getters on TextTrackList and TextTrackCueList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 195
196 void TextTrack::removeAllCues() 196 void TextTrack::removeAllCues()
197 { 197 {
198 if (!m_cues) 198 if (!m_cues)
199 return; 199 return;
200 200
201 if (cueTimeline()) 201 if (cueTimeline())
202 cueTimeline()->removeCues(this, m_cues.get()); 202 cueTimeline()->removeCues(this, m_cues.get());
203 203
204 for (size_t i = 0; i < m_cues->length(); ++i) 204 for (size_t i = 0; i < m_cues->length(); ++i)
205 m_cues->item(i)->setTrack(0); 205 m_cues->anonymousIndexedGetter(i)->setTrack(0);
206 206
207 m_cues = nullptr; 207 m_cues = nullptr;
208 } 208 }
209 209
210 void TextTrack::addListOfCues(HeapVector<Member<TextTrackCue>>& listOfNewCues) 210 void TextTrack::addListOfCues(HeapVector<Member<TextTrackCue>>& listOfNewCues)
211 { 211 {
212 TextTrackCueList* cues = ensureTextTrackCueList(); 212 TextTrackCueList* cues = ensureTextTrackCueList();
213 213
214 for (auto& newCue : listOfNewCues) { 214 for (auto& newCue : listOfNewCues) {
215 newCue->setTrack(this); 215 newCue->setTrack(this);
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 { 474 {
475 visitor->trace(m_cues); 475 visitor->trace(m_cues);
476 visitor->trace(m_activeCues); 476 visitor->trace(m_activeCues);
477 visitor->trace(m_regions); 477 visitor->trace(m_regions);
478 visitor->trace(m_trackList); 478 visitor->trace(m_trackList);
479 TrackBase::trace(visitor); 479 TrackBase::trace(visitor);
480 RefCountedGarbageCollectedEventTargetWithInlineData<TextTrack>::trace(visito r); 480 RefCountedGarbageCollectedEventTargetWithInlineData<TextTrack>::trace(visito r);
481 } 481 }
482 482
483 } // namespace blink 483 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698