Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1417313003: Move GrGLBufferImpl's GL calls to behind GrGLGpu (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrGLBufferImpl's GL calls to behind GrGLGpu BUG=skia: Committed: https://skia.googlesource.com/skia/+/93316b92e565072e2b6fe4147802a9ffaf92eb77

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : bug fix #

Patch Set 4 : tweaks #

Patch Set 5 : tweaks #

Patch Set 6 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -111 lines) Patch
M src/gpu/GrGpu.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 1 2 3 4 6 chunks +10 lines, -103 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 5 1 chunk +113 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
joshualitt
ptal, there is still atleast one odd bug when null hint is disabled. I am ...
5 years, 2 months ago (2015-10-22 20:36:04 UTC) #2
bsalomon
On 2015/10/22 20:36:04, joshualitt wrote: > ptal, there is still atleast one odd bug when ...
5 years, 2 months ago (2015-10-22 21:37:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417313003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417313003/100001
5 years, 2 months ago (2015-10-23 15:21:05 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 16:08:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/93316b92e565072e2b6fe4147802a9ffaf92eb77

Powered by Google App Engine
This is Rietveld 408576698