Experimental CL to stop using subdata

Experimental CL to stop using subdata

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/383ce32e3e5ca0c8997ece827205f61d348ee56f

[joshualitt, 2015-10-23 15:30:55]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-10-23 15:30:55]

ptal

[bsalomon, 2015-10-23 15:38:28]

lgtm

[joshualitt, 2015-10-23 15:44:36]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-10-23 15:44:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413263006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413263006/1

[commit-bot: I haz the power, 2015-10-23 16:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 16:05:46]

Failed to apply patch for src/gpu/gl/GrGLBufferImpl.cpp:
While running git apply --index -3 -p1;
  error: patch failed: src/gpu/gl/GrGLBufferImpl.cpp:99
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: src/gpu/gl/GrGLBufferImpl.cpp: patch does not apply

Patch:       src/gpu/gl/GrGLBufferImpl.cpp
Index: src/gpu/gl/GrGLBufferImpl.cpp
diff --git a/src/gpu/gl/GrGLBufferImpl.cpp b/src/gpu/gl/GrGLBufferImpl.cpp
index
6cbf4e0d0eca4dde0274b31c3624a203f972cd9e..becc55ae6993dd61c5892b30615b0faf3461dfe0
100644
--- a/src/gpu/gl/GrGLBufferImpl.cpp
+++ b/src/gpu/gl/GrGLBufferImpl.cpp
@@ -99,11 +99,7 @@ bool GrGLBufferImpl::updateData(GrGLGpu* gpu, const void*
src, size_t srcSizeInB
     }
     gpu->bufferData(fDesc.fID, fBufferType, fDesc.fDynamic, fDesc.fSizeInBytes,
src,
                     srcSizeInBytes);
-#if GR_GL_USE_BUFFER_DATA_NULL_HINT
-    fGLSizeInBytes = fDesc.fSizeInBytes;
-#else
     fGLSizeInBytes = srcSizeInBytes;
-#endif
     VALIDATE();
     return true;
 }

[joshualitt, 2015-10-23 16:09:10]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-10-23 16:09:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413263006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413263006/1

[commit-bot: I haz the power, 2015-10-23 16:12:05]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/383ce32e3e5ca0c8997ece827205f61d348ee56f

[caryclark, 2015-10-23 17:42:40]

Description was changed from

==========
Experimental CL to stop using subdata

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/383ce32e3e5ca0c8997ece827205f61d348ee56f
==========

to

==========
Experimental CL to stop using subdata

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/383ce32e3e5ca0c8997ece827205f61d348ee56f
==========

[joshualitt, 2015-10-23 20:54:05]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1409123004/ by joshualitt@google.com.

The reason for reverting is: might be breaking tsan.