Issue 14139012: PPAPI: More test cleanup

Issue 14139012: PPAPI: More test cleanup (Closed)

Created:
7 years, 8 months ago by dmichael (off chromium)

Modified:
7 years, 8 months ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI: More test cleanup This removes the last usage of WaitForResult and force_async_, so removes them as well. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194364

Patch Set 1 : merge #

Patch Set 2 : Fix graphics2d tests #

Patch Set 3 : Replace TEST_FORCEASYNC_AND_NOT with RUN_CALLBACK_TEST #

Patch Set 4 : fix failures #

Patch Set 5 : Minor fix, try switching off thread test. #

Patch Set 6 : Fix TCP Server Socket listen test #

Patch Set 7 : Provide a message loop for "background thread" test so we can use a REQUIRED callback #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+391 lines, -606 lines)			Patch
M	ppapi/tests/test_case.h	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	ppapi/tests/test_file_system.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/tests/test_graphics_2d.h	View	1	2 chunks	+5 lines, -8 lines	0 comments	Download
M	ppapi/tests/test_graphics_2d.cc	View	1	29 chunks	+164 lines, -262 lines	0 comments	Download
M	ppapi/tests/test_graphics_3d.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	ppapi/tests/test_host_resolver_private.cc	View		4 chunks	+28 lines, -42 lines	0 comments	Download
M	ppapi/tests/test_host_resolver_private_disallowed.cc	View		2 chunks	+6 lines, -10 lines	0 comments	Download
M	ppapi/tests/test_net_address_private_untrusted.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	ppapi/tests/test_tcp_server_socket_private.cc	View	1 2 3 4 5 6	8 chunks	+55 lines, -75 lines	0 comments	Download
M	ppapi/tests/test_tcp_server_socket_private_disallowed.cc	View		2 chunks	+6 lines, -9 lines	0 comments	Download
M	ppapi/tests/test_tcp_socket_private.cc	View	1 2 3	8 chunks	+64 lines, -83 lines	0 comments	Download
M	ppapi/tests/test_tcp_socket_private_disallowed.cc	View		1 chunk	+4 lines, -8 lines	0 comments	Download
M	ppapi/tests/test_tcp_socket_private_trusted.cc	View		1 chunk	+10 lines, -12 lines	0 comments	Download
M	ppapi/tests/test_udp_socket_private.cc	View	1 2 3	5 chunks	+30 lines, -49 lines	0 comments	Download
M	ppapi/tests/test_udp_socket_private_disallowed.cc	View		1 chunk	+4 lines, -8 lines	0 comments	Download
M	ppapi/tests/test_utils.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	ppapi/tests/test_utils.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bbudge

On 2013/04/12 00:04:05, bbudge1 wrote: > LGTM Nice. Looks like TCPServerSocket got broken somehow.

7 years, 8 months ago (2013-04-12 00:05:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/14139012/22001

7 years, 8 months ago (2013-04-12 17:58:04 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=31820

7 years, 8 months ago (2013-04-12 20:02:58 UTC) #5

dmichael (off chromium)

7 years, 8 months ago (2013-04-16 15:09:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #7 manually as r194364 (presubmit successful).

Expand Messages | Collapse Messages