Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: ppapi/tests/test_tcp_server_socket_private_disallowed.cc

Issue 14139012: PPAPI: More test cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Provide a message loop for "background thread" test so we can use a REQUIRED callback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_tcp_server_socket_private.cc ('k') | ppapi/tests/test_tcp_socket_private.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_tcp_server_socket_private_disallowed.cc
diff --git a/ppapi/tests/test_tcp_server_socket_private_disallowed.cc b/ppapi/tests/test_tcp_server_socket_private_disallowed.cc
index 55a61a6cf8b5fc7009acef041c7965c487e017e2..8c89a3a1e28097683e94bb399629273697d66424 100644
--- a/ppapi/tests/test_tcp_server_socket_private_disallowed.cc
+++ b/ppapi/tests/test_tcp_server_socket_private_disallowed.cc
@@ -53,7 +53,7 @@ bool TestTCPServerSocketPrivateDisallowed::Init() {
}
void TestTCPServerSocketPrivateDisallowed::RunTests(const std::string& filter) {
- RUN_TEST_FORCEASYNC_AND_NOT(Listen, filter);
+ RUN_CALLBACK_TEST(TestTCPServerSocketPrivateDisallowed, Listen, filter);
}
std::string TestTCPServerSocketPrivateDisallowed::TestListen() {
@@ -69,17 +69,14 @@ std::string TestTCPServerSocketPrivateDisallowed::TestListen() {
ASSERT_TRUE(pp::NetAddressPrivate::ReplacePort(base_address,
port,
&current_address));
- TestCompletionCallback callback(instance_->pp_instance(), force_async_);
- int32_t rv = tcp_server_socket_private_interface_->Listen(
+ TestCompletionCallback callback(instance_->pp_instance(), callback_type());
+ callback.WaitForResult(tcp_server_socket_private_interface_->Listen(
socket,
&current_address,
1,
- callback.GetCallback().pp_completion_callback());
- if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
- return ReportError("PPB_TCPServerSocket_Private::Listen force_async", rv);
- if (rv == PP_OK_COMPLETIONPENDING)
- rv = callback.WaitForResult();
- ASSERT_NE(PP_OK, rv);
+ callback.GetCallback().pp_completion_callback()));
+ CHECK_CALLBACK_BEHAVIOR(callback);
+ ASSERT_NE(PP_OK, callback.result());
}
PASS();
« no previous file with comments | « ppapi/tests/test_tcp_server_socket_private.cc ('k') | ppapi/tests/test_tcp_socket_private.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698