Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1598)

Unified Diff: ppapi/tests/test_tcp_socket_private_trusted.cc

Issue 14139012: PPAPI: More test cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Provide a message loop for "background thread" test so we can use a REQUIRED callback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_tcp_socket_private_disallowed.cc ('k') | ppapi/tests/test_udp_socket_private.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_tcp_socket_private_trusted.cc
diff --git a/ppapi/tests/test_tcp_socket_private_trusted.cc b/ppapi/tests/test_tcp_socket_private_trusted.cc
index 82c2257034cb7ed148d6e08b9d3017ff127d0635..1b0e7e7c248b232d4a4a5e8fdca19f411c121c9f 100644
--- a/ppapi/tests/test_tcp_socket_private_trusted.cc
+++ b/ppapi/tests/test_tcp_socket_private_trusted.cc
@@ -35,24 +35,22 @@ bool TestTCPSocketPrivateTrusted::Init() {
}
void TestTCPSocketPrivateTrusted::RunTests(const std::string& filter) {
- RUN_TEST_FORCEASYNC_AND_NOT(GetServerCertificate, filter);
+ RUN_CALLBACK_TEST(TestTCPSocketPrivateTrusted, GetServerCertificate, filter);
}
std::string TestTCPSocketPrivateTrusted::TestGetServerCertificate() {
pp::TCPSocketPrivate socket(instance_);
- TestCompletionCallback cb(instance_->pp_instance(), force_async_);
+ TestCompletionCallback cb(instance_->pp_instance(), callback_type());
- int32_t rv = socket.Connect(host_.c_str(), ssl_port_, cb.GetCallback());
- ASSERT_TRUE(!force_async_ || rv == PP_OK_COMPLETIONPENDING);
- if (rv == PP_OK_COMPLETIONPENDING)
- rv = cb.WaitForResult();
- ASSERT_EQ(PP_OK, rv);
+ cb.WaitForResult(
+ socket.Connect(host_.c_str(), ssl_port_, cb.GetCallback()));
+ CHECK_CALLBACK_BEHAVIOR(cb);
+ ASSERT_EQ(PP_OK, cb.result());
- rv = socket.SSLHandshake(host_.c_str(), ssl_port_, cb.GetCallback());
- ASSERT_TRUE(!force_async_ || rv == PP_OK_COMPLETIONPENDING);
- if (rv == PP_OK_COMPLETIONPENDING)
- rv = cb.WaitForResult();
- ASSERT_EQ(PP_OK, rv);
+ cb.WaitForResult(
+ socket.SSLHandshake(host_.c_str(), ssl_port_, cb.GetCallback()));
+ CHECK_CALLBACK_BEHAVIOR(cb);
+ ASSERT_EQ(PP_OK, cb.result());
const pp::X509CertificatePrivate& cert = socket.GetServerCertificate();
ASSERT_EQ(
« no previous file with comments | « ppapi/tests/test_tcp_socket_private_disallowed.cc ('k') | ppapi/tests/test_udp_socket_private.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698