Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: ppapi/tests/test_tcp_socket_private_disallowed.cc

Issue 14139012: PPAPI: More test cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Provide a message loop for "background thread" test so we can use a REQUIRED callback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_tcp_socket_private.cc ('k') | ppapi/tests/test_tcp_socket_private_trusted.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_tcp_socket_private_disallowed.cc
diff --git a/ppapi/tests/test_tcp_socket_private_disallowed.cc b/ppapi/tests/test_tcp_socket_private_disallowed.cc
index 6325a4f0c33efd3ea03629ac7056bfc216e96a30..581b54b37cc45fc683c85efe9f00f23581ef5932 100644
--- a/ppapi/tests/test_tcp_socket_private_disallowed.cc
+++ b/ppapi/tests/test_tcp_socket_private_disallowed.cc
@@ -39,15 +39,11 @@ std::string TestTCPSocketPrivateDisallowed::TestConnect() {
tcp_socket_private_interface_->Create(instance_->pp_instance());
if (0 != socket) {
TestCompletionCallback callback(instance_->pp_instance());
- int32_t rv = tcp_socket_private_interface_->Connect(
+ callback.WaitForResult(tcp_socket_private_interface_->Connect(
socket, kServerName, kPort,
- callback.GetCallback().pp_completion_callback());
-
- if (PP_OK_COMPLETIONPENDING == rv)
- rv = callback.WaitForResult();
-
- if (PP_ERROR_FAILED != rv)
- return "PPB_TCPSocket_Private can connect without allowing switch";
+ callback.GetCallback().pp_completion_callback()));
+ CHECK_CALLBACK_BEHAVIOR(callback);
+ ASSERT_EQ(PP_ERROR_FAILED, callback.result());
}
PASS();
}
« no previous file with comments | « ppapi/tests/test_tcp_socket_private.cc ('k') | ppapi/tests/test_tcp_socket_private_trusted.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698