ppapi/tests/test_net_address_private_untrusted.cc - Issue 14139012: PPAPI: More test cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/test_net_address_private_untrusted.cc

Issue 14139012: PPAPI: More test cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Provide a message loop for "background thread" test so we can use a REQUIRED callback Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/tests/test_net_address_private_untrusted.cc

diff --git a/ppapi/tests/test_net_address_private_untrusted.cc b/ppapi/tests/test_net_address_private_untrusted.cc

index 7ad64e2fcd925b8a413b7e5c08a25db5464b96cf..06db002788e73b5ff2f2ee6e08c14fa7a5908947 100644

--- a/ppapi/tests/test_net_address_private_untrusted.cc

+++ b/ppapi/tests/test_net_address_private_untrusted.cc

@@ -57,10 +57,9 @@ int32_t TestNetAddressPrivateUntrusted::Connect(TCPSocketPrivate* socket,

uint16_t port) {

TestCompletionCallback callback(instance_->pp_instance(), false);

- int32_t rv = socket->Connect(host.c_str(), port, callback.GetCallback());

- if (rv == PP_OK_COMPLETIONPENDING)

- rv = callback.WaitForResult();

- return rv;

+ callback.WaitForResult(

+ socket->Connect(host.c_str(), port, callback.GetCallback()));

+ return callback.result();

}

std::string TestNetAddressPrivateUntrusted::TestAreEqual() {