Make chrome and other targets compile on Mac GN

Make chrome and other targets compile on Mac GN

The other targets include browser_tests, interactive_ui_tests, sync_integration_tests, extensions_browsertests, content_shell, app_shell.

These targets don't actually run because bundles aren't supported yet.

Committed: https://crrev.com/e1d4065ee1d16e56d5b3267bfb643615454e9ba7
Cr-Commit-Position: refs/heads/master@{#355917}

[brettw, 2015-10-23 03:36:39]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 03:36:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413783003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413783003/1

[commit-bot: I haz the power, 2015-10-23 03:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 03:45:47]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[brettw, 2015-10-23 07:17:08]

Description was changed from

==========
Make chrome and browser tests link on Mac GN

BUG=
==========

to

==========
Make chrome and other targets compile on Mac GN

The other targets include browser_tests, interactive_ui_tests,
sync_integration_tests, extensions_browsertests, content_shell, app_shell.

These targets don't actually run because bundles aren't supported yet.
==========

[brettw, 2015-10-23 07:18:44]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-10-23 07:18:51]

brettw@chromium.org changed reviewers:
+ andybons@chromium.org

[commit-bot: I haz the power, 2015-10-23 07:18:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413783003/20001

[commit-bot: I haz the power, 2015-10-23 07:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 07:24:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-10-23 07:39:59]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 07:40:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413783003/40001

[commit-bot: I haz the power, 2015-10-23 10:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 10:06:01]

Dry run: This issue passed the CQ dry run.

[Bons, 2015-10-23 14:16:01]

lgtm

https://codereview.chromium.org/1413783003/diff/40001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1413783003/diff/40001/BUILD.gn#oldcode498
BUILD.gn:498: # TODO(GYP): These don't work on Mac yet.
THEY DO NOW :)

[brettw, 2015-10-23 22:56:39]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-10-23 22:57:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413783003/40001

[commit-bot: I haz the power, 2015-10-23 23:06:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-23 23:07:39]

Patchset 3 (id:??) landed as
https://crrev.com/e1d4065ee1d16e56d5b3267bfb643615454e9ba7
Cr-Commit-Position: refs/heads/master@{#355917}