Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2174)

Unified Diff: content/shell/BUILD.gn

Issue 1413783003: Make chrome and other targets compile on Mac GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeOS fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index 4bfdd9fdb1c911816005a326c39727541b2bee86..f3b26add95fe8c105c7e04fc7463bf2ea3f4a525 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -430,7 +430,12 @@ if (!is_android && !is_mac) {
}
if (is_mac) {
- # TODO(GYP) lots of stuff from GYP file here.
+ # TODO(GYP) lots of stuff from GYP file here including helper_app and
+ # postbuilds.
+ output_name = content_shell_product_name
+ deps = [
+ ":framework",
+ ]
}
if (is_android) {
@@ -467,3 +472,24 @@ if (is_win) {
configs += [ "//build/config/win:windowed" ]
}
}
+
+if (is_mac) {
+ # TODO(GYP) this should be a bundle. Lots of other stuff in this target.
+ # GYP version: content/content_shell.gypi:content_shell_framework
+ shared_library("framework") {
+ testonly = true
+
+ # TODO(GYP) bug 546894: Fix GN and toolchains to handle spaces here.
+ #output_name = "$content_shell_product_name Framework"
+ output_name = "content_shell_framework" # Temporary one with no spaces.
+
+ sources = [
+ "shell_content_main.cc",
+ "shell_content_main.h",
+ ]
+
+ deps = [
+ ":content_shell_lib",
+ ]
+ }
+}
« BUILD.gn ('K') | « content/content_shell.gypi ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698