Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: BUILD.gn

Issue 1413783003: Make chrome and other targets compile on Mac GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeOS fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 7f3dd9f73add25347c8636148880ca44eda02961..bfc0fc88a448d04ee57ef55f41e753146e438ea4 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -494,18 +494,10 @@ group("both_gn_and_gyp") {
"//third_party/apple_sample_code",
"//third_party/molokocacao",
]
-
- # TODO(GYP): These don't work on Mac yet.
Bons 2015/10/23 14:16:01 THEY DO NOW :)
deps -= [
- "//chrome", # TODO(GYP)
- "//chrome/test:browser_tests", # TODO(GYP)
- "//chrome/test:interactive_ui_tests", # TODO(GYP)
- "//chrome/test:sync_integration_tests", # TODO(GYP)
- "//extensions:extensions_browsertests", # TODO(GYP) Needs ContentMain
-
# Mojo in GN contains some things which are never compiled in GYP on Mac,
# so compilation fails on Mac. They need porting.
- "//mojo", # TODO(GYP)
+ "//mojo",
]
}
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698