Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: extensions/shell/BUILD.gn

Issue 1413783003: Make chrome and other targets compile on Mac GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeOS fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//extensions/shell/app_shell.gni") 5 import("//extensions/shell/app_shell.gni")
6 6
7 # Technically, this directory should not depend on files from src/chrome, but 7 # Technically, this directory should not depend on files from src/chrome, but
8 # that's where the VERSION file is. This should probably all be moved to 8 # that's where the VERSION file is. This should probably all be moved to
9 # src/build. 9 # src/build.
10 import("//chrome/version.gni") 10 import("//chrome/version.gni")
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 "//extensions:shell_and_test_pak", 149 "//extensions:shell_and_test_pak",
150 ] 150 ]
151 151
152 if (is_win) { 152 if (is_win) {
153 configs += [ "//build/config/win:windowed" ] 153 configs += [ "//build/config/win:windowed" ]
154 configs -= [ "//build/config/win:console" ] 154 configs -= [ "//build/config/win:console" ]
155 deps += [ "//base/allocator" ] 155 deps += [ "//base/allocator" ]
156 } 156 }
157 157
158 if (is_mac) { 158 if (is_mac) {
159 # TODO(GYP): Mac bundling 159 # TODO(GYP) bug 546894: Fix GN and toolchains to handle spaces here.
160 #output_name = "App Shell"
161 # TODO(GYP): Mac bundling. See also content_shell which this is basically
162 # a copy-paste of.
163 deps += [ ":app_shell_framework" ]
164 # TODO(GYP): Mac app_shell_helper stuff.
160 } 165 }
161 } 166 }
162 } 167 }
163 168
164 # TODO(GYP): Delete this after we've converted everything to GN. 169 # TODO(GYP): Delete this after we've converted everything to GN.
165 # The _run targets exist only for compatibility w/ GYP. 170 # The _run targets exist only for compatibility w/ GYP.
166 group("app_shell_unittests_run") { 171 group("app_shell_unittests_run") {
167 testonly = true 172 testonly = true
168 deps = [ 173 deps = [
169 ":app_shell_unittests", 174 ":app_shell_unittests",
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 236
232 if (is_win) { 237 if (is_win) {
233 deps += [ "//base/allocator" ] 238 deps += [ "//base/allocator" ]
234 } 239 }
235 } 240 }
236 241
237 process_version("version_header") { 242 process_version("version_header") {
238 template_file = "common/version.h.in" 243 template_file = "common/version.h.in"
239 output = "$target_gen_dir/common/version.h" 244 output = "$target_gen_dir/common/version.h"
240 } 245 }
246
247 if (is_mac) {
248 # TODO(GYP) this should be a bundle. Lots of other stuff in this target.
249 # Should be able to copy content shell framework (this is basically a
250 # copy-paste of that target).
251 shared_library("app_shell_framework") {
252 testonly = true
253 sources = [
254 "app/shell_main_mac.cc",
255 "app/shell_main_mac.h",
256 ]
257 deps = [
258 ":app_shell_lib",
259 ]
260 }
261 }
OLDNEW
« BUILD.gn ('K') | « content/shell/BUILD.gn ('k') | extensions/shell/app_shell.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698