Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: extensions/shell/BUILD.gn

Issue 1413783003: Make chrome and other targets compile on Mac GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeOS fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/BUILD.gn
diff --git a/extensions/shell/BUILD.gn b/extensions/shell/BUILD.gn
index 06bf717200944e47499fd9f16706ba5691962f84..0e318979efef49369d986445823601e82e6fed29 100644
--- a/extensions/shell/BUILD.gn
+++ b/extensions/shell/BUILD.gn
@@ -156,7 +156,12 @@ if (!(is_chromeos && !use_ozone)) {
}
if (is_mac) {
- # TODO(GYP): Mac bundling
+ # TODO(GYP) bug 546894: Fix GN and toolchains to handle spaces here.
+ #output_name = "App Shell"
+ # TODO(GYP): Mac bundling. See also content_shell which this is basically
+ # a copy-paste of.
+ deps += [ ":app_shell_framework" ]
+ # TODO(GYP): Mac app_shell_helper stuff.
}
}
}
@@ -238,3 +243,19 @@ process_version("version_header") {
template_file = "common/version.h.in"
output = "$target_gen_dir/common/version.h"
}
+
+if (is_mac) {
+ # TODO(GYP) this should be a bundle. Lots of other stuff in this target.
+ # Should be able to copy content shell framework (this is basically a
+ # copy-paste of that target).
+ shared_library("app_shell_framework") {
+ testonly = true
+ sources = [
+ "app/shell_main_mac.cc",
+ "app/shell_main_mac.h",
+ ]
+ deps = [
+ ":app_shell_lib",
+ ]
+ }
+}
« BUILD.gn ('K') | « content/shell/BUILD.gn ('k') | extensions/shell/app_shell.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698