Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412123015: Replace open-coded toSVG<type> with DEFINE_SVG_PROPERTY_TYPE_CASTS (Closed)

Created:
5 years, 1 month ago by fs
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace open-coded toSVG<type> with DEFINE_SVG_PROPERTY_TYPE_CASTS Also replace some includes of SVGAnimated*.h with SVG*.h where the latter will suffice. (* = {Integer,Number,Property}) Relocate the DEFINE_SVG_PROPERTY_TYPE_CASTS macro to SVGProperty.h. Committed: https://crrev.com/fe572d824f5959d06a20fdceb1bc5293487daad9 Cr-Commit-Position: refs/heads/master@{#357783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -112 lines) Patch
M third_party/WebKit/Source/core/animation/LengthSVGInterpolation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedColor.h View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGBoolean.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEnumeration.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGInteger.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGIntegerOptionalInteger.h View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthList.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberList.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberOptionalNumber.h View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPath.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPoint.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointList.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRect.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGString.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGProperty.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGPropertyHelper.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
fs
alancutter added this spiffy macro in https://codereview.chromium.org/1410643011 (thanks!), so let's use that all over (I ...
5 years, 1 month ago (2015-11-03 17:47:54 UTC) #2
pdr.
LGTM
5 years, 1 month ago (2015-11-03 19:20:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412123015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412123015/1
5 years, 1 month ago (2015-11-03 19:27:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/129676)
5 years, 1 month ago (2015-11-03 21:32:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412123015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412123015/1
5 years, 1 month ago (2015-11-03 21:38:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/129785)
5 years, 1 month ago (2015-11-04 00:38:50 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412123015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412123015/1
5 years, 1 month ago (2015-11-04 00:42:30 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 02:06:35 UTC) #15
alancutter (OOO until 2018)
On 2015/11/04 at 02:06:35, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
5 years, 1 month ago (2015-11-04 07:36:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412123015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412123015/1
5 years, 1 month ago (2015-11-04 08:43:18 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 08:47:05 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 08:48:03 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fe572d824f5959d06a20fdceb1bc5293487daad9
Cr-Commit-Position: refs/heads/master@{#357783}

Powered by Google App Engine
This is Rietveld 408576698