Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: third_party/WebKit/Source/core/svg/properties/SVGProperty.h

Issue 1412123015: Replace open-coded toSVG<type> with DEFINE_SVG_PROPERTY_TYPE_CASTS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 private: 100 private:
101 const AnimatedPropertyType m_type; 101 const AnimatedPropertyType m_type;
102 102
103 // Oilpan: the back reference to the owner should be a Member, but this can create 103 // Oilpan: the back reference to the owner should be a Member, but this can create
104 // cycles when SVG properties meet the off-heap InterpolationValue hierarchy . 104 // cycles when SVG properties meet the off-heap InterpolationValue hierarchy .
105 // Not tracing it is safe, albeit an undesirable state of affairs. 105 // Not tracing it is safe, albeit an undesirable state of affairs.
106 GC_PLUGIN_IGNORE("528275") 106 GC_PLUGIN_IGNORE("528275")
107 SVGPropertyBase* m_ownerList; 107 SVGPropertyBase* m_ownerList;
108 }; 108 };
109 109
110 #define DEFINE_SVG_PROPERTY_TYPE_CASTS(thisType)\
111 DEFINE_TYPE_CASTS(thisType, SVGPropertyBase, value, value->type() == thisTyp e::classType(), value.type() == thisType::classType());\
112 inline PassRefPtrWillBeRawPtr<thisType> to##thisType(PassRefPtrWillBeRawPtr< SVGPropertyBase> passBase)\
113 {\
114 RefPtrWillBeRawPtr<SVGPropertyBase> base = passBase;\
115 ASSERT(base->type() == thisType::classType());\
116 return static_pointer_cast<thisType>(base.release());\
117 }
118
110 } 119 }
111 120
112 #endif // SVGProperty_h 121 #endif // SVGProperty_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698