Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/core/svg/properties/SVGPropertyHelper.h

Issue 1412123015: Replace open-coded toSVG<type> with DEFINE_SVG_PROPERTY_TYPE_CASTS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/properties/SVGProperty.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SVGPropertyHelper_h 5 #ifndef SVGPropertyHelper_h
6 #define SVGPropertyHelper_h 6 #define SVGPropertyHelper_h
7 7
8 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 8 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
9 #include "core/svg/properties/SVGProperty.h" 9 #include "core/svg/properties/SVGProperty.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 template<typename Derived> 13 template<typename Derived>
14 class SVGPropertyHelper : public SVGPropertyBase { 14 class SVGPropertyHelper : public SVGPropertyBase {
15 public: 15 public:
16 SVGPropertyHelper() 16 SVGPropertyHelper()
17 : SVGPropertyBase(Derived::classType()) 17 : SVGPropertyBase(Derived::classType())
18 { 18 {
19 } 19 }
20 20
21 virtual PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const Stri ng& value) const 21 virtual PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const Stri ng& value) const
22 { 22 {
23 RefPtrWillBeRawPtr<Derived> property = Derived::create(); 23 RefPtrWillBeRawPtr<Derived> property = Derived::create();
24 property->setValueAsString(value, IGNORE_EXCEPTION); 24 property->setValueAsString(value, IGNORE_EXCEPTION);
25 return property.release(); 25 return property.release();
26 } 26 }
27 }; 27 };
28 28
29 #define DEFINE_SVG_PROPERTY_TYPE_CASTS(thisType)\
30 DEFINE_TYPE_CASTS(thisType, SVGPropertyBase, value, value->type() == thisTyp e::classType(), value.type() == thisType::classType());\
31 inline PassRefPtrWillBeRawPtr<thisType> to##thisType(PassRefPtrWillBeRawPtr< SVGPropertyBase> passBase)\
32 {\
33 RefPtrWillBeRawPtr<SVGPropertyBase> base = passBase;\
34 ASSERT(base->type() == thisType::classType());\
35 return static_pointer_cast<thisType>(base.release());\
36 }
37
38
39 } // namespace blink 29 } // namespace blink
40 30
41 #endif // SVGPropertyHelper_h 31 #endif // SVGPropertyHelper_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/properties/SVGProperty.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698