Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1410643011: Web Animations: Add SVGNumberInterpolationType (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_propertyHandleFilter
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Add SVGNumberInterpolationType This change migrates the following SVG attribute animations over to SVGNumberInterpolationType and enables additive keyframe composite modes as well as neutral keyframes: amplitude, azimuth, bias, diffuseConstant, divisor, elevation, exponent, intercept, k1, k2, k3, k4, limitingConeAngle, offset, pathLength, pointsAtX, pointsAtY, pointsAtZ, scale, seed, slope, specularConstant, specularExponent, surfaceScale, z. BUG=530436 Committed: https://crrev.com/7549261292f268f29e8fdf11802b69bc2b7c6165 Cr-Commit-Position: refs/heads/master@{#357454}

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : Rebased #

Patch Set 4 : Add tests #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1616 lines, -43 lines) Patch
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-amplitude-composition.html View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-azimuth-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-bias-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-diffuseConstant-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-divisor-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-elevation-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-exponent-composition.html View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-intercept-composition.html View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-k1-k2-k3-k4-composition.html View 1 2 3 1 chunk +205 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-limitingConeAngle-composition.html View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition.html View 1 2 3 1 chunk +50 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-offset-composition-expected.txt View 1 2 3 4 1 chunk +0 lines, -17 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-pathLength-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-pointsAtX-pointsAtY-pointsAtZ-composition.html View 1 2 3 1 chunk +157 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-scale-composition.html View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-seed-composition.html View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-slope-composition.html View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-specularConstant-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-specularExponent-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-surfaceScale-composition.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-z-composition.html View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/NumberAttributeFunctions.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGNumberInterpolationType.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGNumberInterpolationType.cpp View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 2 3 5 chunks +37 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumber.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGProperty.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGPropertyHelper.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (12 generated)
dstockwell
lgtm
5 years, 1 month ago (2015-11-02 04:15:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410643011/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410643011/60001
5 years, 1 month ago (2015-11-02 04:37:52 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/88726) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-02 04:40:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410643011/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410643011/60001
5 years, 1 month ago (2015-11-02 05:55:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/89948) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-02 05:57:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410643011/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410643011/60001
5 years, 1 month ago (2015-11-02 12:36:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410643011/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410643011/80001
5 years, 1 month ago (2015-11-02 17:48:42 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/82752)
5 years, 1 month ago (2015-11-02 18:34:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410643011/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410643011/80001
5 years, 1 month ago (2015-11-02 22:18:54 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-02 22:39:28 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 22:40:35 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7549261292f268f29e8fdf11802b69bc2b7c6165
Cr-Commit-Position: refs/heads/master@{#357454}

Powered by Google App Engine
This is Rietveld 408576698