Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1411283009: Reland Reland Reland Switch Chrome Android using v8 arch specific external data name (Closed)

Created:
5 years, 1 month ago by michaelbai
Modified:
5 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, vmpstr+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, lcwu+watch_chromium.org, jam, Peter Beverloo, darin-cc_chromium.org, mikecase+watch_chromium.org, halliwell+watch_chromium.org, blink-reviews, gunsch+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org, yfriedman+watch_chromium.org, agrieve, Miguel Garcia, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Reland Reland Switch Chrome Android using v8 arch specific external data name This patch changed all android GN target which use v8 snapshot files as of it being prepared. origin patch https://codereview.chromium.org/1422793004/ This patch also fix package_resource.py issue that asset's renaming didn't trigger the packaging. origin patch https://codereview.chromium.org/1417753004/ Switch Chrome Android using v8 arch specific external data name For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. This patch also removed the existing v8 startup data in destination directory by using copy_ex to remove directory first. BUG=540788, 547235 TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org Committed: https://crrev.com/01630673ae102e70913ac6832fa994c50a1514b5 Cr-Commit-Position: refs/heads/master@{#357577}

Patch Set 1 #

Patch Set 2 : add missed BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -76 lines) Patch
M base/android/java/src/org/chromium/base/ApkAssets.java View 1 chunk +0 lines, -13 lines 0 comments Download
M build/android/gyp/package_resources.py View 1 chunk +13 lines, -2 lines 0 comments Download
A build/android/v8_external_startup_data_arch_suffix.gypi View 1 chunk +21 lines, -0 lines 0 comments Download
M build_overrides/v8.gni View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 3 chunks +15 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chromecast/chromecast.gyp View 3 chunks +9 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 3 chunks +15 lines, -8 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content.gyp View 2 chunks +6 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +6 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +11 lines, -4 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +2 lines, -4 lines 0 comments Download
M gin/v8_initializer.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 1 chunk +2 lines, -4 lines 0 comments Download
M net/net.gyp View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
michaelbai
jbudorick@ comparing to reverted patch, this patch change some GN targets which were added after ...
5 years, 1 month ago (2015-11-03 05:47:35 UTC) #3
michaelbai
On 2015/11/03 05:47:35, michaelbai wrote: > jbudorick@ comparing to reverted patch, this patch change some ...
5 years, 1 month ago (2015-11-03 05:48:41 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411283009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411283009/20001
5 years, 1 month ago (2015-11-03 05:49:25 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/131234)
5 years, 1 month ago (2015-11-03 07:00:47 UTC) #8
jbudorick
lgtm On 2015/11/03 05:47:35, michaelbai wrote: > jbudorick@ comparing to reverted patch, this patch change ...
5 years, 1 month ago (2015-11-03 16:56:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411283009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411283009/20001
5 years, 1 month ago (2015-11-03 18:39:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 19:48:17 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 19:49:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01630673ae102e70913ac6832fa994c50a1514b5
Cr-Commit-Position: refs/heads/master@{#357577}

Powered by Google App Engine
This is Rietveld 408576698