Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: components/components_tests.gyp

Issue 1411283009: Reland Reland Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missed BUILD.gn Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/chromecast.gyp ('k') | components/html_viewer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/components_tests.gyp
diff --git a/components/components_tests.gyp b/components/components_tests.gyp
index 5ef7bd8e47e2ace3f9f7b24752e45436a8d2d882..be711d95db4013c77f9c728cf4e43949bd1d5f29 100644
--- a/components/components_tests.gyp
+++ b/components/components_tests.gyp
@@ -1464,14 +1464,9 @@
'<(PRODUCT_DIR)/icudtl.dat',
],
}],
- ['v8_use_external_startup_data==1', {
- 'components_browsertests_pak_input_resources': [
- '<(PRODUCT_DIR)/natives_blob.bin',
- '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
- }],
],
},
+ 'includes': ['../build/android/v8_external_startup_data_arch_suffix.gypi'],
'targets': [
{
'target_name': 'components_browsertests_paks_copy',
@@ -1485,6 +1480,18 @@
'<@(components_browsertests_pak_input_resources)',
],
'clear': 1,
+ 'conditions': [
+ ['v8_use_external_startup_data==1', {
+ 'renaming_sources': [
+ '<(PRODUCT_DIR)/natives_blob.bin',
+ '<(PRODUCT_DIR)/snapshot_blob.bin',
+ ],
+ 'renaming_destinations': [
+ 'natives_blob_<(arch_suffix).bin',
+ 'snapshot_blob_<(arch_suffix).bin',
+ ],
+ }],
+ ],
},
'includes': ['../build/android/copy_ex.gypi'],
},
@@ -1524,8 +1531,8 @@
}],
['v8_use_external_startup_data==1', {
'additional_input_paths': [
- '<(asset_location)/natives_blob.bin',
- '<(asset_location)/snapshot_blob.bin',
+ '<(asset_location)/natives_blob_<(arch_suffix).bin',
+ '<(asset_location)/snapshot_blob_<(arch_suffix).bin',
],
}],
],
« no previous file with comments | « chromecast/chromecast.gyp ('k') | components/html_viewer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698