Reland Reland Switch Chrome Android using v8 arch specific external data name

Reland Reland Switch Chrome Android using v8 arch specific external data name

This patch also fix package_resource.py issue that asset's
renaming didn't trigger the packaging.

origin patch
https://codereview.chromium.org/1417753004/

Switch Chrome Android using v8 arch specific external data name

For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used.
For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used.

This patch also removed the existing v8 startup data in
destination directory by using copy_ex to remove directory
first.

BUG=540788, 547235
TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org

Committed: https://crrev.com/02d6496adfb377afc0708e53cd0c8118c0591f99
Cr-Commit-Position: refs/heads/master@{#357480}

[michaelbai, 2015-10-24 05:03:30]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-24 05:03:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422793004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422793004/20001

[commit-bot: I haz the power, 2015-10-24 05:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-24 05:16:34]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)

[michaelbai, 2015-10-25 04:52:37]

Patchset #2 (id:20001) has been deleted

[michaelbai, 2015-10-25 04:53:56]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-25 04:54:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422793004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422793004/40001

[commit-bot: I haz the power, 2015-10-25 05:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-25 05:57:06]

Dry run: This issue passed the CQ dry run.

[michaelbai, 2015-10-26 04:08:19]

michaelbai@chromium.org changed reviewers:
- cpu@chromium.org, dpranke@chromium.org, dtrainor@chromium.org,
halliwell@chromium.org, jochen@chromium.org, mef@chromium.org,
rmcilroy@chromium.org

[michaelbai, 2015-10-26 04:08:19]

jbudorick@, this fix wrong dependences, difference between patch 1 and patch 2
is the change from reverted patch.

[michaelbai, 2015-10-26 04:10:14]

Description was changed from

==========
Reland Reland Switch Chrome Android using v8 arch specific external data name

This patch fix the wrong dependences for files in assets directory.

origin patch
https://codereview.chromium.org/1417753004/

Switch Chrome Android using v8 arch specific external data name

For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used.
For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used.

This patch also removed the existing v8 startup data in
destination directory by using copy_ex to remove directory
first.

BUG=540788

TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick...
==========

to

==========
Reland Reland Switch Chrome Android using v8 arch specific external data name

This patch fix the wrong dependences for files in assets directory.

origin patch
https://codereview.chromium.org/1417753004/

Switch Chrome Android using v8 arch specific external data name

For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used.
For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used.

This patch also removed the existing v8 startup data in
destination directory by using copy_ex to remove directory
first.

BUG=540788,547235 

TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick...
==========

[jbudorick, 2015-10-26 23:02:05]

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gyp:541: 'includes':
['../build/android/v8_external_startup_data_arch_suffix.gypi',],
Curious -- why did you move this outside?

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gyp:551: 'dest_path': '<(PRODUCT_DIR)/assets',
Shouldn't this be copying to something target-specific rather than
<(PRODUCT_DIR)/assets/? Couldn't that collide with other targets?

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.g...
content/content_shell.gypi:938:
'<(PRODUCT_DIR)/content_shell/assets/icudtl.dat',
<(asset_location)/icudtl.dat

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.g...
content/content_shell.gypi:943:
'<(PRODUCT_DIR)/content_shell/assets/natives_blob_<(arch_suffix).bin',
similarly, <(asset_location)/native_blob_<(arch_suffix).bin

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.g...
content/content_shell.gypi:944:
'<(PRODUCT_DIR)/content_shell/assets/snapshot_blob_<(arch_suffix).bin',
here too

https://codereview.chromium.org/1422793004/diff/40001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/1422793004/diff/40001/content/content_tests.g...
content/content_tests.gypi:1896:
'<(PRODUCT_DIR)/content_unittests_apk/assets/natives_blob_<(arch_suffix).bin',
<(asset_location)/natives_blob_<(arch_suffix).bin

https://codereview.chromium.org/1422793004/diff/40001/content/content_tests.g...
content/content_tests.gypi:1897:
'<(PRODUCT_DIR)/content_unittests_apk/assets/snapshot_blob_<(arch_suffix).bin',
same

https://codereview.chromium.org/1422793004/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/net/net.gyp#newcode1547
net/net.gyp:1547:
'<(PRODUCT_DIR)/net_unittests_apk/assets/natives_blob_<(arch_suffix).bin',
<(asset_location)/natives_blob_<(arch_suffix).bin

https://codereview.chromium.org/1422793004/diff/40001/net/net.gyp#newcode1548
net/net.gyp:1548:
'<(PRODUCT_DIR)/net_unittests_apk/assets/snapshot_blob_<(arch_suffix).bin',
same

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/blink_platform_tests.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/blink_platform_tests.gyp:168:
'<(PRODUCT_DIR)/blink_heap_unittests_apk/assets/natives_blob_<(arch_suffix).bin',
same

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/web_tests.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/web_tests.gyp:156:
'<(PRODUCT_DIR)/content_shell/assets/natives_blob_<(arch_suffix).bin',
same

[michaelbai, 2015-10-27 01:10:43]

Fix some, others wouldn't work because variable can be declared and referenced
in the same condition block.

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gyp:541: 'includes':
['../build/android/v8_external_startup_data_arch_suffix.gypi',],
On 2015/10/26 23:02:04, jbudorick wrote:
> Curious -- why did you move this outside?

Because the arch_suffix variable is needed by 2 targets

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gyp:551: 'dest_path': '<(PRODUCT_DIR)/assets',
On 2015/10/26 23:02:04, jbudorick wrote:
> Shouldn't this be copying to something target-specific rather than
> <(PRODUCT_DIR)/assets/? Couldn't that collide with other targets?

It doesn't collide with others now because one one report errors, but I changed
it for sake of safe.

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.g...
content/content_shell.gypi:938:
'<(PRODUCT_DIR)/content_shell/assets/icudtl.dat',
On 2015/10/26 23:02:04, jbudorick wrote:
> <(asset_location)/icudtl.dat

Done.

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.g...
content/content_shell.gypi:943:
'<(PRODUCT_DIR)/content_shell/assets/natives_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:04, jbudorick wrote:
> similarly, <(asset_location)/native_blob_<(arch_suffix).bin

Done.

https://codereview.chromium.org/1422793004/diff/40001/content/content_shell.g...
content/content_shell.gypi:944:
'<(PRODUCT_DIR)/content_shell/assets/snapshot_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:04, jbudorick wrote:
> here too

Done.

https://codereview.chromium.org/1422793004/diff/40001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/1422793004/diff/40001/content/content_tests.g...
content/content_tests.gypi:1896:
'<(PRODUCT_DIR)/content_unittests_apk/assets/natives_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:04, jbudorick wrote:
> <(asset_location)/natives_blob_<(arch_suffix).bin

wouldn't work, can use declared variable in the condition

https://codereview.chromium.org/1422793004/diff/40001/content/content_tests.g...
content/content_tests.gypi:1897:
'<(PRODUCT_DIR)/content_unittests_apk/assets/snapshot_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:04, jbudorick wrote:
> same

ditto

https://codereview.chromium.org/1422793004/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/net/net.gyp#newcode1547
net/net.gyp:1547:
'<(PRODUCT_DIR)/net_unittests_apk/assets/natives_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:04, jbudorick wrote:
> <(asset_location)/natives_blob_<(arch_suffix).bin

ditto

https://codereview.chromium.org/1422793004/diff/40001/net/net.gyp#newcode1548
net/net.gyp:1548:
'<(PRODUCT_DIR)/net_unittests_apk/assets/snapshot_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:04, jbudorick wrote:
> same

ditto

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/blink_platform_tests.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/blink_platform_tests.gyp:168:
'<(PRODUCT_DIR)/blink_heap_unittests_apk/assets/natives_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:04, jbudorick wrote:
> same

ditto

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/web_tests.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/web_tests.gyp:156:
'<(PRODUCT_DIR)/content_shell/assets/natives_blob_<(arch_suffix).bin',
On 2015/10/26 23:02:05, jbudorick wrote:
> same

Done.

[michaelbai, 2015-10-27 01:12:58]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 01:13:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422793004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422793004/60001

[jbudorick, 2015-10-27 01:14:58]

lgtm

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gyp:541: 'includes':
['../build/android/v8_external_startup_data_arch_suffix.gypi',],
On 2015/10/27 01:10:42, michaelbai wrote:
> On 2015/10/26 23:02:04, jbudorick wrote:
> > Curious -- why did you move this outside?
> 
> Because the arch_suffix variable is needed by 2 targets 

ah, ok. Makes sense.

https://codereview.chromium.org/1422793004/diff/40001/chromecast/chromecast.g...
chromecast/chromecast.gyp:551: 'dest_path': '<(PRODUCT_DIR)/assets',
On 2015/10/27 01:10:42, michaelbai wrote:
> On 2015/10/26 23:02:04, jbudorick wrote:
> > Shouldn't this be copying to something target-specific rather than
> > <(PRODUCT_DIR)/assets/? Couldn't that collide with other targets?
> 
> It doesn't collide with others now because one one report errors, but I
changed
> it for sake of safe.

Thanks.

[commit-bot: I haz the power, 2015-10-27 01:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 01:21:46]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)

[michaelbai, 2015-10-27 02:38:24]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2015-10-27 02:38:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1422793004/#ps80001
(title: "fix cast")

[commit-bot: I haz the power, 2015-10-27 02:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422793004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422793004/80001

[commit-bot: I haz the power, 2015-10-27 02:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 02:57:10]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)

[michaelbai, 2015-10-27 04:33:30]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2015-10-27 04:33:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1422793004/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-10-27 04:33:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422793004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422793004/100001

[commit-bot: I haz the power, 2015-10-27 08:34:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 08:34:59]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Miguel Garcia, 2015-10-27 10:40:01]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2015-10-27 10:40:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422793004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422793004/100001

[jbudorick, 2015-10-27 13:16:55]

The CQ bit was unchecked by jbudorick@chromium.org

[jbudorick, 2015-10-27 13:17:36]

On 2015/10/27 10:40:16, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1422793004/100001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1422793004/100001

I pulled this out of the CQ. I want to look at why it has failed
ContentShellTest in three consecutive runs of linux_android_rel_ng.

[jbudorick, 2015-10-27 13:22:11]

On 2015/10/27 13:17:36, jbudorick wrote:
> On 2015/10/27 10:40:16, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1422793004/100001
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1422793004/100001
> 
> I pulled this out of the CQ. I want to look at why it has failed
> ContentShellTest in three consecutive runs of linux_android_rel_ng.

All three runs failed 250 of 432 tests, and they all crashed. Something is wrong
with this CL. I'll look at the logcats when I'm on a better connection.

[michaelbai, 2015-10-27 16:21:02]

On 2015/10/27 13:22:11, jbudorick wrote:
> On 2015/10/27 13:17:36, jbudorick wrote:
> > On 2015/10/27 10:40:16, commit-bot: I haz the power wrote:
> > > CQ is trying da patch. Follow status at
> > >  https://chromium-cq-status.appspot.com/patch-status/1422793004/100001
> > > View timeline at
> > >  https://chromium-cq-status.appspot.com/patch-timeline/1422793004/100001
> > 
> > I pulled this out of the CQ. I want to look at why it has failed
> > ContentShellTest in three consecutive runs of linux_android_rel_ng.
> 
> All three runs failed 250 of 432 tests, and they all crashed. Something is
wrong
> with this CL. I'll look at the logcats when I'm on a better connection.

hmm, same error

236b6:  10-27 11:19:39.109 20211 20211 E ApkAssets: Error while loading asset
assets/snapshot_blob_32.bin: java.io.FileNotFoundException:
assets/snapshot_blob_32.bin
236b6:  10-27 11:19:39.109 20211 20211 E ApkAssets: Error while loading asset
assets/natives_blob_32.bin: java.io.FileNotFoundException:
assets/natives_blob_32.bin
236b6:  10-27 11:19:39.119 20211 20211 F chromium:
[20211:20211:1027/111939:1344067491:FATAL:v8_initializer.cc(282)] Couldn't mmap
v8 natives data file, status code is 1

[jbudorick, 2015-10-27 16:22:18]

On 2015/10/27 16:21:02, michaelbai wrote:
> On 2015/10/27 13:22:11, jbudorick wrote:
> > On 2015/10/27 13:17:36, jbudorick wrote:
> > > On 2015/10/27 10:40:16, commit-bot: I haz the power wrote:
> > > > CQ is trying da patch. Follow status at
> > > >  https://chromium-cq-status.appspot.com/patch-status/1422793004/100001
> > > > View timeline at
> > > >  https://chromium-cq-status.appspot.com/patch-timeline/1422793004/100001
> > > 
> > > I pulled this out of the CQ. I want to look at why it has failed
> > > ContentShellTest in three consecutive runs of linux_android_rel_ng.
> > 
> > All three runs failed 250 of 432 tests, and they all crashed. Something is
> wrong
> > with this CL. I'll look at the logcats when I'm on a better connection.
> 
> hmm, same error
> 
> 236b6:  10-27 11:19:39.109 20211 20211 E ApkAssets: Error while loading asset
> assets/snapshot_blob_32.bin: java.io.FileNotFoundException:
> assets/snapshot_blob_32.bin
> 236b6:  10-27 11:19:39.109 20211 20211 E ApkAssets: Error while loading asset
> assets/natives_blob_32.bin: java.io.FileNotFoundException:
> assets/natives_blob_32.bin
> 236b6:  10-27 11:19:39.119 20211 20211 F chromium:
> [20211:20211:1027/111939:1344067491:FATAL:v8_initializer.cc(282)] Couldn't
mmap
> v8 natives data file, status code is 1

Worryingly, this still passed one (of four) runs of linux_android_rel_ng.

[michaelbai, 2015-11-02 19:39:52]

Description was changed from

==========
Reland Reland Switch Chrome Android using v8 arch specific external data name

This patch fix the wrong dependences for files in assets directory.

origin patch
https://codereview.chromium.org/1417753004/

Switch Chrome Android using v8 arch specific external data name

For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used.
For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used.

This patch also removed the existing v8 startup data in
destination directory by using copy_ex to remove directory
first.

BUG=540788,547235 

TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick...
==========

to

==========
Reland Reland Switch Chrome Android using v8 arch specific external data name

This patch also fix package_resource.py issue that asset's
renaming didn't trigger the packaging.

origin patch
https://codereview.chromium.org/1417753004/

Switch Chrome Android using v8 arch specific external data name

For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used.
For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used.

This patch also removed the existing v8 startup data in
destination directory by using copy_ex to remove directory
first.

BUG=540788,547235 

TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick...
==========

[michaelbai, 2015-11-02 19:48:23]

PTAL, The fix is in build/android/gyp/package_resources.py

[jbudorick, 2015-11-02 22:10:08]

lgtm

[michaelbai, 2015-11-02 22:35:48]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2015-11-02 22:37:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422793004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422793004/180001

[commit-bot: I haz the power, 2015-11-03 00:23:22]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2015-11-03 00:24:31]

Patchset 9 (id:??) landed as
https://crrev.com/02d6496adfb377afc0708e53cd0c8118c0591f99
Cr-Commit-Position: refs/heads/master@{#357480}

[Sam McNally, 2015-11-03 03:29:18]

A revert of this CL (patchset #9 id:180001) has been created in
https://codereview.chromium.org/1432553003/ by sammc@chromium.org.

The reason for reverting is: Looks like it caused Android GN net_unittests to
crash:
https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/3188...;
suspect it's crashing a ProxyResolverV8 test..