content/content.gyp - Issue 1411283009: Reland Reland Reland Switch Chrome Android using v8 arch specific external data name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/content.gyp

Issue 1411283009: Reland Reland Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missed BUILD.gn Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/content.gyp

diff --git a/content/content.gyp b/content/content.gyp

index bda908c81f5d73167a61465232a541fa232b1138..f1a2a973f5afe5161b90f73931056a9d0f611420 100644

--- a/content/content.gyp

+++ b/content/content.gyp

@@ -638,10 +638,14 @@

'conditions': [

['v8_use_external_startup_data==1', {

'dependencies': ['<(DEPTH)/v8/tools/gyp/v8.gyp:v8_external_snapshot'],

- 'src_files': [

+ 'renaming_sources': [

'<(PRODUCT_DIR)/natives_blob.bin',

'<(PRODUCT_DIR)/snapshot_blob.bin',

+ 'renaming_destinations': [

+ 'natives_blob_<(arch_suffix).bin',

+ 'snapshot_blob_<(arch_suffix).bin',

+ ],

}],

['icu_use_data_file_flag==1', {

'dependencies': ['<(DEPTH)/third_party/icu/icu.gyp:icudata'],

@@ -653,6 +657,7 @@

'includes': [

'../build/android/copy_ex.gypi',

+ '../build/android/v8_external_startup_data_arch_suffix.gypi',

« no previous file with comments | « components/html_viewer/BUILD.gn ('k') | content/content_shell.gypi » ('j') | no next file with comments »