components/html_viewer/BUILD.gn - Issue 1411283009: Reland Reland Reland Switch Chrome Android using v8 arch specific external data name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/BUILD.gn

Issue 1411283009: Reland Reland Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missed BUILD.gn Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/html_viewer/BUILD.gn

diff --git a/components/html_viewer/BUILD.gn b/components/html_viewer/BUILD.gn

index 894d6b3ce1b297e21be1c24f8f78d91bccc78961..3497f8ad004fd1afbcaf62187d4cc151bbfcc0d4 100644

--- a/components/html_viewer/BUILD.gn

+++ b/components/html_viewer/BUILD.gn

@@ -302,9 +302,9 @@ if (is_android) {

sources = [

"$root_build_dir/html_viewer.pak",

"$root_build_dir/icudtl.dat",

- "$root_out_dir/natives_blob.bin",

- "$root_out_dir/snapshot_blob.bin",

]

+ renaming_sources = v8_external_startup_data_renaming_sources

+ renaming_destinations = v8_external_startup_data_renaming_destinations

}

generate_mojo_shell_assets_list("build_unittest_assets") {

« no previous file with comments | « components/components_tests.gyp ('k') | content/content.gyp » ('j') | no next file with comments »