third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp - Issue 1410993004: Make PropertyHandle::svgAttribute() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp

Issue 1410993004: Make PropertyHandle::svgAttribute() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_unCSSInterpolationType

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/PropertyHandle.h ('k') | third_party/WebKit/Source/core/animation/StringKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp b/third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp

index ffe6d32bc2689afaa257284b88fb835b1698c524..4ce9ff4f6a4fe0ab2ae3bc83579bc8655e343bb6 100644

--- a/third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp

+++ b/third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp

@@ -53,7 +53,7 @@ TEST_F(PropertyHandleTest, Accessors)

EXPECT_FALSE(PropertyHandle(CSSPropertyOpacity).isSVGAttribute());

EXPECT_TRUE(PropertyHandle(amplitudeAttr).isSVGAttribute());

- EXPECT_EQ(PropertyHandle(amplitudeAttr).svgAttribute(), &amplitudeAttr);

+ EXPECT_EQ(PropertyHandle(amplitudeAttr).svgAttribute(), amplitudeAttr);

}