Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1394343003: Web Animations: Remove CSS dependence from InterpolationType (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_specialCase0and1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Remove CSS dependence from InterpolationType This change is part of adding keyframe composite mode support to SVG Web Animations by generalising InterpolationTypes to more than just CSS animations. New class: InterpolationEnvironment Forked class: InterpolationType => InterpolationType, CSSInterpolationType BUG=530436 Committed: https://crrev.com/cc0dda5dde6dc62ef6c5af2e08c690552ea8d835 Cr-Commit-Position: refs/heads/master@{#356479}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebase #

Patch Set 4 : Rebased #

Patch Set 5 : Rebase and split #

Patch Set 6 : NIVs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -204 lines) Patch
A third_party/WebKit/Source/core/animation/CSSInterpolationType.h View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ColorInterpolationType.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ColorInterpolationType.cpp View 1 2 3 4 5 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImageInterpolationType.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImageInterpolationType.cpp View 1 2 3 4 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImageListInterpolationType.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImageListInterpolationType.cpp View 1 2 3 4 7 chunks +11 lines, -11 lines 0 comments Download
A third_party/WebKit/Source/core/animation/InterpolationEnvironment.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationType.h View 1 2 3 4 6 chunks +13 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h View 1 2 3 4 2 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.cpp View 1 2 3 4 11 chunks +33 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthInterpolationType.h View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthInterpolationType.cpp View 1 2 3 4 5 8 chunks +18 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/animation/NumberInterpolationType.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/NumberInterpolationType.cpp View 1 2 3 4 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PaintInterpolationType.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PaintInterpolationType.cpp View 1 2 3 4 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ShadowListInterpolationType.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ShadowListInterpolationType.cpp View 1 2 3 4 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
alancutter (OOO until 2018)
5 years, 2 months ago (2015-10-20 23:43:42 UTC) #3
Eric Willigers
lgtm
5 years, 2 months ago (2015-10-24 06:45:21 UTC) #4
alancutter (OOO until 2018)
Rebased patch onto several new CSSInterpolationTypes. Split class renames out into separate patches: https://codereview.chromium.org/1409073009, https://codereview.chromium.org/1412313005 ...
5 years, 1 month ago (2015-10-26 01:15:36 UTC) #6
alancutter (OOO until 2018)
On 2015/10/26 at 01:15:36, alancutter wrote: > Rebased patch onto several new CSSInterpolationTypes. > Split ...
5 years, 1 month ago (2015-10-27 23:58:47 UTC) #7
dstockwell
lgtm
5 years, 1 month ago (2015-10-28 00:09:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394343003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394343003/100001
5 years, 1 month ago (2015-10-28 00:14:10 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-10-28 01:44:28 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 01:45:08 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/cc0dda5dde6dc62ef6c5af2e08c690552ea8d835
Cr-Commit-Position: refs/heads/master@{#356479}

Powered by Google App Engine
This is Rietveld 408576698