Hide internal methods like wrap_jso from the dart:html public interface

Hide internal methods like wrap_jso from the dart:html public interface

Issue https://github.com/dart-lang/sdk/issues/24602

R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/a9362610ee429a0b69653635039696f86976f564

[Alan Knight, 2015-10-16 20:14:38]

alanknight@google.com changed reviewers:
+ terry@google.com

[Alan Knight, 2015-10-16 20:14:38]

This required moving a reasonable amount of stuff around, and makes isBadUpgrade
public on Element. It hides wrap_jso, unwrap_jso, some convertDartToNative...
and specialized wrap_jso methods by moving them into html_common. Some other
private things are moved into html_common but then need to be public.

Note: NOT TBR.

[kevmoo, 2015-10-16 21:34:25]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-10-16 21:34:25]

DBC: see nit on deprecation notice

https://codereview.chromium.org/1409743003/diff/20001/tools/dom/templates/htm...
File tools/dom/templates/html/impl/impl_HTMLElement.darttemplate (right):

https://codereview.chromium.org/1409743003/diff/20001/tools/dom/templates/htm...
tools/dom/templates/html/impl/impl_HTMLElement.darttemplate:15: /// Internal use
only. Did this encounter a failure attempting to upgrade to
Format a clear first line.

/// Required for SDK infrastructure. Internal use only.
///
/// Did this encounter...

Put the same text in @Deprecated('Required for SDK infrastructure. Internal use
only.')

[Alan Knight, 2015-10-16 22:58:30]

https://codereview.chromium.org/1409743003/diff/20001/tools/dom/templates/htm...
File tools/dom/templates/html/impl/impl_HTMLElement.darttemplate (right):

https://codereview.chromium.org/1409743003/diff/20001/tools/dom/templates/htm...
tools/dom/templates/html/impl/impl_HTMLElement.darttemplate:15: /// Internal use
only. Did this encounter a failure attempting to upgrade to
On 2015/10/16 21:34:25, kevmoo wrote:
> Format a clear first line.
> 
> /// Required for SDK infrastructure. Internal use only.
> ///
> /// Did this encounter...
> 
> Put the same text in @Deprecated('Required for SDK infrastructure. Internal
use
> only.')

Done.

[kevmoo, 2015-10-16 23:00:14]

https://codereview.chromium.org/1409743003/diff/40001/tools/dom/templates/htm...
File tools/dom/templates/html/impl/impl_HTMLElement.darttemplate (right):

https://codereview.chromium.org/1409743003/diff/40001/tools/dom/templates/htm...
tools/dom/templates/html/impl/impl_HTMLElement.darttemplate:17: /// Did this
encounter a failure attempting to upgrade to
Also tweak this a bit?

"Returns `true` if a failure occur while attempting an upgrade to a custom
element; otherwise `false`."

[terry, 2015-10-19 17:11:25]

lgtm just a few suggestions.

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
File sdk/lib/html/html_common/conversions_dartium.dart (right):

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/conversions_dartium.dart:111: bool __interop_checks =
false;
Should this be hidden?  Looks like we're not hiding anything in html_common.

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/conversions_dartium.dart:367: var knownCustomElements =
new Map<String, Map<Type, String>>();
We don't want anyone really accessing knownCustomElements without our accessors
below.  Probably should be hidden?

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/conversions_dartium.dart:385: class
_DartHtmlWrappingList extends ListBase implements NativeFieldWrapperClass2 {
Doesn't need to be hidden?

[Alan Knight, 2015-10-19 18:28:02]

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
File sdk/lib/html/html_common/conversions_dartium.dart (right):

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/conversions_dartium.dart:111: bool __interop_checks =
false;
On 2015/10/19 17:11:25, terry wrote:
> Should this be hidden?  Looks like we're not hiding anything in html_common.

Done.

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/conversions_dartium.dart:367: var knownCustomElements =
new Map<String, Map<Type, String>>();
On 2015/10/19 17:11:25, terry wrote:
> We don't want anyone really accessing knownCustomElements without our
accessors
> below.  Probably should be hidden?

Done.

https://codereview.chromium.org/1409743003/diff/40001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/conversions_dartium.dart:385: class
_DartHtmlWrappingList extends ListBase implements NativeFieldWrapperClass2 {
On 2015/10/19 17:11:25, terry wrote:
> Doesn't need to be hidden?

Done.

https://codereview.chromium.org/1409743003/diff/40001/tools/dom/templates/htm...
File tools/dom/templates/html/impl/impl_HTMLElement.darttemplate (right):

https://codereview.chromium.org/1409743003/diff/40001/tools/dom/templates/htm...
tools/dom/templates/html/impl/impl_HTMLElement.darttemplate:17: /// Did this
encounter a failure attempting to upgrade to
On 2015/10/16 23:00:13, kevmoo wrote:
> Also tweak this a bit?
> 
> "Returns `true` if a failure occur while attempting an upgrade to a custom
> element; otherwise `false`."

The return type is bool, so it's pretty clear it returns true or false. I think
the name and the comment make it pretty clear which way is true and which way is
false. So that seems gratuitous to me.

[Alan Knight, 2015-10-19 18:28:59]

Committed patchset #4 (id:60001) manually as
a9362610ee429a0b69653635039696f86976f564 (presubmit successful).