Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: tools/dom/src/dartium_CustomElementSupport.dart

Issue 1409743003: Hide internal methods like wrap_jso from the dart:html public interface (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Review fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/src/dartium_CustomElementSupport.dart
diff --git a/tools/dom/src/dartium_CustomElementSupport.dart b/tools/dom/src/dartium_CustomElementSupport.dart
index c91ab72034051200832e2bb5ca8e29b0265eb8ce..aec7b4af1dcae0f39a7d5d5ff3252c6f34ba4d1b 100644
--- a/tools/dom/src/dartium_CustomElementSupport.dart
+++ b/tools/dom/src/dartium_CustomElementSupport.dart
@@ -53,16 +53,16 @@ class _VMElementUpgrader implements ElementUpgrader {
// Element to extend is the real tag.
tag = element.localName;
- } else if (tag != null && element.localName != tag) {
+ } else if (tag != null && element.localName != tag) {
throw new UnsupportedError('Element is incorrect type. Got ${element.runtimeType}, expected native Html or Svg element to extend.');
} else if (tag == null) {
throw new UnsupportedError('Element is incorrect type. Got ${element.runtimeType}, expected HtmlElement/JsObjectImpl.');
}
// Remember Dart class to tagName for any upgrading done in wrap_jso.
- _addCustomElementType(tag, _type, _extendsTag);
+ addCustomElementType(tag, _type, _extendsTag);
- return createCustomUpgrader(_type, jsObject);
+ return _createCustomUpgrader(_type, jsObject);
}
}
« no previous file with comments | « tests/html/wrapping_collections_test.dart ('k') | tools/dom/templates/html/dartium/html_dartium.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698