tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate - Issue 1409743003: Hide internal methods like wrap_jso from the dart:html public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

Issue 1409743003: Hide internal methods like wrap_jso from the dart:html public interface (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Review fixes Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/dartium/html_dartium.darttemplate ('k') | tools/dom/templates/html/impl/impl_HTMLElement.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

index 959c49493227627f842a18c27f1e429d16e375fa..1df549ea47fd88a320ab661c4723aa1138c2c771 100644

--- a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

+++ b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

@@ -394,7 +394,7 @@ $else

var nativeElement = document.createElement(extendsTag);

// Trying to extend a native element is it the Dart class consistent with the

- // extendsTag?

+ // extendsTag?

if (nativeElement.runtimeType != customClassType.reflectedType) {

var nativeElementClassMirror = reflectClass(nativeElement.runtimeType);

var customClassNativeElement = MirrorSystem.getName(customClassType.simpleName);

@@ -422,7 +422,7 @@ $else

var elemProto = js.JsNative.callMethod(js.JsNative.getProperty(js.context, 'Object'), "create", [js.JsNative.getProperty(baseElement, 'prototype')]);

// Remember for any upgrading done in wrap_jso.

- _addCustomElementType(tag, customElementClass, extendsTag);

+ addCustomElementType(tag, customElementClass, extendsTag);

// TODO(terry): Hack to stop recursion re-creating custom element when the

// created() constructor of the custom element does e.g.,