Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: sdk/lib/js/dartium/js_dartium.dart

Issue 1409743003: Hide internal methods like wrap_jso from the dart:html public interface (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Review fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/html_common/html_common.dart ('k') | tests/html/wrapping_collections_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/js/dartium/js_dartium.dart
diff --git a/sdk/lib/js/dartium/js_dartium.dart b/sdk/lib/js/dartium/js_dartium.dart
index 13e701230724d32c0d714672d5169ed482ae7a78..26134dd084a250fd3430b8b62d30a8ac5ebc40e6 100644
--- a/sdk/lib/js/dartium/js_dartium.dart
+++ b/sdk/lib/js/dartium/js_dartium.dart
@@ -92,6 +92,7 @@ import 'dart:nativewrappers';
import 'dart:math' as math;
import 'dart:mirrors' as mirrors;
import 'dart:html' as html;
+import 'dart:html_common' as html_common;
import 'dart:indexed_db' as indexed_db;
import 'dart:typed_data';
@@ -700,7 +701,7 @@ JsObject get context {
}
_maybeWrap(o) {
- var wrapped = html.wrap_jso_no_SerializedScriptvalue(o);
+ var wrapped = html_common.wrap_jso_no_SerializedScriptvalue(o);
if (identical(wrapped, o)) return o;
return (wrapped is html.Blob
|| wrapped is html.Event
@@ -819,7 +820,7 @@ class JsObject extends NativeFieldWrapperClass2 {
static JsObject _jsify(object) native "JsObject_jsify";
- static JsObject _fromBrowserObject(object) => html.unwrap_jso(object);
+ static JsObject _fromBrowserObject(object) => html_common.unwrap_jso(object);
/**
* Returns the value associated with [property] from the proxied JavaScript
@@ -858,7 +859,7 @@ class JsObject extends NativeFieldWrapperClass2 {
operator ==(other) {
var is_JsObject = other is JsObject;
if (!is_JsObject) {
- other = html.unwrap_jso(other);
+ other = html_common.unwrap_jso(other);
is_JsObject = other is JsObject;
}
return is_JsObject && _identityEquality(this, other);
« no previous file with comments | « sdk/lib/html/html_common/html_common.dart ('k') | tests/html/wrapping_collections_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698