Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

Issue 1409743003: Hide internal methods like wrap_jso from the dart:html public interface (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Review fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate b/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
index fdc305fd37bc4d832495e3ab84520a14fd083bf5..1d126319e53388315f106ecdf964f9255fe309a9 100644
--- a/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
+++ b/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
@@ -8,10 +8,17 @@ part of $LIBRARYNAME;
$(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {
$!MEMBERS
$if DARTIUM
- // Flags to only try upgrading once if there's a failure don't try upgrading
+ // Flags to only try upgrading once. If there's a failure don't try upgrading
// anymore.
bool _badUpgradeOccurred = false;
- bool get _isBadUpgrade => _badUpgradeOccurred;
+
+ /// Required for SDK Infrastructure. Internal use only.
+ ///
+ /// Did this encounter a failure attempting to upgrade to
+ /// a custom element.
+ @Deprecated("Required for SDK Infrastructure. Internal use only.")
+ bool get isBadUpgrade => _badUpgradeOccurred;
+
void _badUpgrade() { _badUpgradeOccurred = true; }
$endif
}
« no previous file with comments | « tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698