XFA: Remove cond ? TRUE : FALSE.

XFA: Remove cond ? TRUE : FALSE.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/23378cdf2c0be861bddfffd82aed8cd6b07d77bf

[Lei Zhang, 2015-10-19 19:20:35]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-10-19 19:20:35]

!!

[Tom Sepez, 2015-10-19 20:16:10]

https://codereview.chromium.org/1409323003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_progress.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:719: FX_BOOL bLastPass = ((row_num
% 2) == 1);
nit: overparenthesized.

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fdp/src/tto/fde_tex...
File xfa/src/fdp/src/tto/fde_textout.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fdp/src/tto/fde_tex...
xfa/src/fdp/src/tto/fde_textout.cpp:316: FX_BOOL bLineWrap = (m_dwStyles &
FDE_TTOSTYLE_LineWrap);
missing !!.

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
File xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp:872: return
!!(m_pEdit->AddSelRange(0) == FWL_ERR_Succeeded);
These three are already booleans, no need for !!, and then no need for ().

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
File xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp:665: return
!!(m_pEdit->AddSelRange(0) == FWL_ERR_Succeeded);
This three as well.

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/core/fwl_fo...
File xfa/src/fwl/src/core/fwl_formimp.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/core/fwl_fo...
xfa/src/fwl/src/core/fwl_formimp.cpp:888: return !!pData->GetIcon(m_pInterface,
FALSE);
what's the return type on this?  Is it already bool?

[Lei Zhang, 2015-10-20 00:36:56]

Patchset #2 (id:20001) has been deleted

[Lei Zhang, 2015-10-20 00:41:43]

https://codereview.chromium.org/1409323003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_progress.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_progress.cpp:719: FX_BOOL bLastPass = ((row_num
% 2) == 1);
On 2015/10/19 20:16:10, Tom Sepez wrote:
> nit: overparenthesized.

Done.

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fdp/src/tto/fde_tex...
File xfa/src/fdp/src/tto/fde_textout.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fdp/src/tto/fde_tex...
xfa/src/fdp/src/tto/fde_textout.cpp:316: FX_BOOL bLineWrap = (m_dwStyles &
FDE_TTOSTYLE_LineWrap);
On 2015/10/19 20:16:10, Tom Sepez wrote:
> missing !!.

Done.

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
File xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp:872: return
!!(m_pEdit->AddSelRange(0) == FWL_ERR_Succeeded);
On 2015/10/19 20:16:10, Tom Sepez wrote:
> These three are already booleans, no need for !!, and then no need for ().

I think this was right before lunch time, so hunger / lack of caffeine set in.

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
File xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/basewidget/...
xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp:665: return
!!(m_pEdit->AddSelRange(0) == FWL_ERR_Succeeded);
On 2015/10/19 20:16:10, Tom Sepez wrote:
> This three as well.

Done. Done. Done.

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/core/fwl_fo...
File xfa/src/fwl/src/core/fwl_formimp.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/core/fwl_fo...
xfa/src/fwl/src/core/fwl_formimp.cpp:888: return !!pData->GetIcon(m_pInterface,
FALSE);
On 2015/10/19 20:16:10, Tom Sepez wrote:
> what's the return type on this?  Is it already bool?

It's a pointer. xfa/include/fwl/core/fwl_form.h line 48.

[Tom Sepez, 2015-10-20 16:33:15]

lgtm

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/core/fwl_fo...
File xfa/src/fwl/src/core/fwl_formimp.cpp (right):

https://codereview.chromium.org/1409323003/diff/1/xfa/src/fwl/src/core/fwl_fo...
xfa/src/fwl/src/core/fwl_formimp.cpp:888: return !!pData->GetIcon(m_pInterface,
FALSE);
On 2015/10/20 00:41:43, Lei Zhang wrote:
> On 2015/10/19 20:16:10, Tom Sepez wrote:
> > what's the return type on this?  Is it already bool?
> 
> It's a pointer. xfa/include/fwl/core/fwl_form.h line 48.

Acknowledged.

[Lei Zhang, 2015-10-20 17:21:44]

Committed patchset #2 (id:40001) manually as
23378cdf2c0be861bddfffd82aed8cd6b07d77bf (presubmit successful).