xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp - Issue 1409323003: XFA: Remove cond ? TRUE : FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp

Issue 1409323003: XFA: Remove cond ? TRUE : FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp

diff --git a/xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp b/xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp

index 1894480068e95c8bb5f025aa05e65f6b79f49c71..4ab1dc96f256c52aeaffec825fe32f7126378869 100644

--- a/xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp

+++ b/xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp

@@ -1432,7 +1432,7 @@ FX_BOOL CXFA_LayoutPageMgr::GetNextAvailContentHeight(FX_FLOAT fChildHeight) {

if (pCurContentNode) {

FX_FLOAT fNextContentHeight =

pCurContentNode->GetMeasure(XFA_ATTRIBUTE_H).ToUnit(XFA_UNIT_Pt);

- return fNextContentHeight > fChildHeight ? TRUE : FALSE;

+ return fNextContentHeight > fChildHeight;

}

CXFA_Node* pPageNode = GetCurrentContainerRecord()->pCurPageArea->m_pFormNode;

CXFA_Node* pOccurNode = pPageNode->GetFirstChildByClass(XFA_ELEMENT_Occur);