xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp - Issue 1409323003: XFA: Remove cond ? TRUE : FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp

Issue 1409323003: XFA: Remove cond ? TRUE : FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp

diff --git a/xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp b/xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp

index dfbf22d7dc27c95c21ec966aba5cef07d77db6d0..7919395a569d449446cd7cbb63591fa105a92c41 100644

--- a/xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp

+++ b/xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp

@@ -314,7 +314,7 @@ int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_Normal(

if (m_pNodeHelper->XFA_NodeIsTransparent((CXFA_Node*)curNode)) {

m_pNodeHelper->XFA_CountSiblings(

(CXFA_Node*)nodes[0], XFA_LOGIC_Transparent, &upArrayNodes,

- dwStyles & XFA_RESOLVENODE_TagName ? TRUE : FALSE);

+ !!(dwStyles & XFA_RESOLVENODE_TagName));

}

if (upArrayNodes.GetSize() > nodes.GetSize()) {

upArrayNodes[0] = (CXFA_Node*)nodes[0];

@@ -463,7 +463,7 @@ int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_Normal(

CXFA_NodeArray upArrayNodes;