xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp - Issue 1409323003: XFA: Remove cond ? TRUE : FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp

Issue 1409323003: XFA: Remove cond ? TRUE : FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp

diff --git a/xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp b/xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp

index 42652ad57aa5d6028f2cd3815a5d9ba8eafaf0ef..8da91847fcb55751f45fb8fba434448932837ddb 100644

--- a/xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp

+++ b/xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp

@@ -1201,7 +1201,7 @@ static void XFA_DataMerge_UpdateBindingRelations(CXFA_Document* pDocument,

if (pDataNode) {

XFA_DataMerge_CreateDataBinding(

pFormNode, pDataNode,

- rs.dwFlags == XFA_RESOVENODE_RSTYPE_ExistNodes ? TRUE : FALSE);

+ rs.dwFlags == XFA_RESOVENODE_RSTYPE_ExistNodes);

} else {

XFA_DataMerge_FormValueNode_MatchNoneCreateChild(pFormNode);

}