xfa/src/fxfa/src/parser/xfa_script_imp.cpp - Issue 1409323003: XFA: Remove cond ? TRUE : FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/parser/xfa_script_imp.cpp

Issue 1409323003: XFA: Remove cond ? TRUE : FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/parser/xfa_script_imp.cpp

diff --git a/xfa/src/fxfa/src/parser/xfa_script_imp.cpp b/xfa/src/fxfa/src/parser/xfa_script_imp.cpp

index f8b8f76ae9d845e68c284da50ed00a4174008f02..34668ea66ab9c9e97c2e0bb01b0b69cb6951b23b 100644

--- a/xfa/src/fxfa/src/parser/xfa_script_imp.cpp

+++ b/xfa/src/fxfa/src/parser/xfa_script_imp.cpp

@@ -672,7 +672,7 @@ int32_t CXFA_ScriptContext::ResolveObjects(CXFA_Object* refNode,

FX_BOOL bCreate =

m_pResolveProcessor->GetNodeHelper()->XFA_ResolveNodes_CreateNode(

rndFind.m_wsName, rndFind.m_wsCondition,

- nStart == wsExpression.GetLength() ? TRUE : FALSE, this);

+ nStart == wsExpression.GetLength(), this);

if (bCreate) {

continue;

} else {

@@ -732,7 +732,7 @@ int32_t CXFA_ScriptContext::ResolveObjects(CXFA_Object* refNode,