Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 140853008: Revert of Fast blurred rectangles on GPU (Closed)

Created:
6 years, 10 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
humper, bsalomon, rmistry, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Fast blurred rectangles on GPU (https://codereview.chromium.org/119343003/) Reason for revert: Two problems: 1. broke compile on Build-Mac10.6-* bots 2. broke GM expectations on many bots We'll need to examine the GM impact before re-landing. I can work with you to do this on Tuesday if you like; just IM or email me. Original issue's description: > Perform the same analytic blur calculation on the GPU that we do on the CPU. Results in significant performance gains when using Ganesh to render drop shadows in Chrome. > > BUG= > > Committed: http://code.google.com/p/skia/source/detail?r=13210 TBR=bsalomon@google.com,reed@google.com,humper@google.com NOTREECHECKS=true NOTRY=true BUG= Committed: http://code.google.com/p/skia/source/detail?r=13213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -375 lines) Patch
M gyp/effects.gypi View 2 chunks +1 line, -1 line 0 comments Download
M include/core/SkMaskFilter.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/effects/SkBlurMask.h View 1 chunk +0 lines, -35 lines 0 comments Download
M src/effects/SkBlurMask.cpp View 6 chunks +35 lines, -37 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +0 lines, -276 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Created Revert of Fast blurred rectangles on GPU
6 years, 10 months ago (2014-01-28 01:21:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/140853008/1
6 years, 10 months ago (2014-01-28 01:21:12 UTC) #2
commit-bot: I haz the power
Presubmit check for 140853008-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 10 months ago (2014-01-28 01:21:17 UTC) #3
rmistry
LGTM
6 years, 10 months ago (2014-01-28 01:51:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/140853008/1
6 years, 10 months ago (2014-01-28 01:55:08 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 01:55:30 UTC) #6
Message was sent while issue was closed.
Change committed as 13213

Powered by Google App Engine
This is Rietveld 408576698