Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140753005: Add the UI compositor to the Mac build (Closed)

Created:
6 years, 11 months ago by ccameron
Modified:
6 years, 11 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, jbauman+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, yukishiino+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Add the UI compositor to the Mac build Move the bulk of the files in content/browser/aura to content/browser/compositor, since they're not aura-specific. Build all of those files in the Mac build, and add ui/compositor to the dependencies of the Mac build. These files will soon only be excluded from the Android build. BUG=314190 > Originally submitted: > https://codereview.chromium.org/137893007 > Then reverted: > https://codereview.chromium.org/137853019 (bug 335083) This submission has the failing test disabled. TBR=piman,danakj Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -2862 lines) Patch
M WATCHLISTS View 1 chunk +2 lines, -1 line 0 comments Download
D content/browser/aura/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/browser/aura/browser_compositor_output_surface.h View 1 chunk +0 lines, -74 lines 0 comments Download
D content/browser/aura/browser_compositor_output_surface.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D content/browser/aura/browser_compositor_output_surface_proxy.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/aura/browser_compositor_output_surface_proxy.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D content/browser/aura/compositor_resize_lock.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/aura/compositor_resize_lock.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D content/browser/aura/gpu_browser_compositor_output_surface.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/aura/gpu_browser_compositor_output_surface.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/aura/gpu_process_transport_factory.h View 1 chunk +0 lines, -95 lines 0 comments Download
D content/browser/aura/gpu_process_transport_factory.cc View 1 chunk +0 lines, -485 lines 0 comments Download
D content/browser/aura/image_transport_factory.h View 1 chunk +0 lines, -94 lines 0 comments Download
D content/browser/aura/image_transport_factory.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/aura/image_transport_factory_browsertest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D content/browser/aura/no_transport_image_transport_factory.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/browser/aura/no_transport_image_transport_factory.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D content/browser/aura/owned_mailbox.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/aura/owned_mailbox.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D content/browser/aura/reflector_impl.h View 1 chunk +0 lines, -125 lines 0 comments Download
D content/browser/aura/reflector_impl.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D content/browser/aura/resize_lock.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/browser/aura/resize_lock.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D content/browser/aura/software_browser_compositor_output_surface.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/aura/software_browser_compositor_output_surface.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D content/browser/aura/software_browser_compositor_output_surface_unittest.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D content/browser/aura/software_output_device_ozone.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/browser/aura/software_output_device_ozone.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D content/browser/aura/software_output_device_ozone_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D content/browser/aura/software_output_device_win.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/aura/software_output_device_win.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D content/browser/aura/software_output_device_x11.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/aura/software_output_device_x11.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/compositor/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/compositor/browser_compositor_output_surface.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/browser_compositor_output_surface.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/compositor/browser_compositor_output_surface_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/browser_compositor_output_surface_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/compositor/gpu_browser_compositor_output_surface.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/compositor/gpu_process_transport_factory.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/compositor/gpu_process_transport_factory.cc View 3 chunks +10 lines, -10 lines 0 comments Download
A + content/browser/compositor/image_transport_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/image_transport_factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/image_transport_factory_browsertest.cc View 2 chunks +11 lines, -3 lines 0 comments Download
A + content/browser/compositor/no_transport_image_transport_factory.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/compositor/no_transport_image_transport_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/compositor/owned_mailbox.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/compositor/owned_mailbox.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/compositor/reflector_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/compositor/reflector_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/compositor/resize_lock.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/resize_lock.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/compositor/software_browser_compositor_output_surface.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/compositor/software_output_device_ozone.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/software_output_device_ozone.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/compositor/software_output_device_ozone_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/compositor/software_output_device_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/software_output_device_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/compositor/software_output_device_x11.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/compositor/software_output_device_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/renderer_host/compositor_resize_lock_aura.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/renderer_host/compositor_resize_lock_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/desktop_capture_device_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 6 chunks +37 lines, -30 lines 0 comments Download
M content/content_tests.gypi View 6 chunks +18 lines, -8 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/140753005/1
6 years, 11 months ago (2014-01-16 20:11:43 UTC) #1
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 22:20:00 UTC) #2
Message was sent while issue was closed. 
Change committed as 245352

Powered by Google App Engine
This is Rietveld 408576698