Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 137853019: Revert 245131 "Add the UI compositor to the Mac build", which caused Mac ASan redness (Closed)

Created:
6 years, 11 months ago by Alexander Potapenko
Modified:
6 years, 11 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245131 "Add the UI compositor to the Mac build", which caused Mac ASan redness > Add the UI compositor to the Mac build > > Move the bulk of the files in content/browser/aura to > content/browser/compositor, since they're not aura-specific. > > Build all of those files in the Mac build, and add ui/compositor > to the dependencies of the Mac build. These files will soon only > be excluded from the Android build. > > BUG=314190 > > Review URL: https://codereview.chromium.org/137893007 TBR=ccameron@chromium.org BUG=335083 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2739 lines) Patch
M trunk/src/WATCHLISTS View 1 chunk +1 line, -2 lines 0 comments Download
A + trunk/src/content/browser/aura/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/browser_compositor_output_surface.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/browser_compositor_output_surface.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/browser_compositor_output_surface_proxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/browser_compositor_output_surface_proxy.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/compositor_resize_lock.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/compositor_resize_lock.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/gpu_browser_compositor_output_surface.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/gpu_browser_compositor_output_surface.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/gpu_process_transport_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/gpu_process_transport_factory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/image_transport_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/image_transport_factory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/image_transport_factory_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/no_transport_image_transport_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/no_transport_image_transport_factory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/owned_mailbox.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/owned_mailbox.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/reflector_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/reflector_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/resize_lock.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/resize_lock.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_browser_compositor_output_surface.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_browser_compositor_output_surface.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_browser_compositor_output_surface_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_output_device_ozone.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_output_device_ozone.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_output_device_ozone_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_output_device_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_output_device_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_output_device_x11.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/browser/aura/software_output_device_x11.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/content/browser/compositor/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D trunk/src/content/browser/compositor/browser_compositor_output_surface.h View 1 chunk +0 lines, -74 lines 0 comments Download
D trunk/src/content/browser/compositor/browser_compositor_output_surface.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D trunk/src/content/browser/compositor/browser_compositor_output_surface_proxy.h View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/src/content/browser/compositor/browser_compositor_output_surface_proxy.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D trunk/src/content/browser/compositor/gpu_browser_compositor_output_surface.h View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/src/content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +0 lines, -95 lines 0 comments Download
D trunk/src/content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +0 lines, -485 lines 0 comments Download
D trunk/src/content/browser/compositor/image_transport_factory.h View 1 chunk +0 lines, -94 lines 0 comments Download
D trunk/src/content/browser/compositor/image_transport_factory.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D trunk/src/content/browser/compositor/image_transport_factory_browsertest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D trunk/src/content/browser/compositor/no_transport_image_transport_factory.h View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/src/content/browser/compositor/no_transport_image_transport_factory.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D trunk/src/content/browser/compositor/owned_mailbox.h View 1 chunk +0 lines, -43 lines 0 comments Download
D trunk/src/content/browser/compositor/owned_mailbox.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D trunk/src/content/browser/compositor/reflector_impl.h View 1 chunk +0 lines, -125 lines 0 comments Download
D trunk/src/content/browser/compositor/reflector_impl.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D trunk/src/content/browser/compositor/resize_lock.h View 1 chunk +0 lines, -37 lines 0 comments Download
D trunk/src/content/browser/compositor/resize_lock.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D trunk/src/content/browser/compositor/software_browser_compositor_output_surface.h View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D trunk/src/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D trunk/src/content/browser/compositor/software_output_device_ozone.h View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/content/browser/compositor/software_output_device_ozone.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D trunk/src/content/browser/compositor/software_output_device_ozone_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D trunk/src/content/browser/compositor/software_output_device_win.h View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/src/content/browser/compositor/software_output_device_win.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D trunk/src/content/browser/compositor/software_output_device_x11.h View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/content/browser/compositor/software_output_device_x11.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D trunk/src/content/browser/renderer_host/compositor_resize_lock_aura.h View 1 chunk +0 lines, -46 lines 0 comments Download
D trunk/src/content/browser/renderer_host/compositor_resize_lock_aura.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M trunk/src/content/browser/renderer_host/media/desktop_capture_device_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/content_browser.gypi View 6 chunks +30 lines, -37 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 6 chunks +8 lines, -18 lines 0 comments Download
M trunk/src/content/public/test/browser_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
6 years, 11 months ago (2014-01-16 14:36:39 UTC) #1
Alexander Potapenko
6 years, 11 months ago (2014-01-16 14:38:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245195 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698