Add the UI compositor to the Mac build

Add the UI compositor to the Mac build

Move the bulk of the files in content/browser/aura to
content/browser/compositor, since they're not aura-specific.

Build all of those files in the Mac build, and add ui/compositor
to the dependencies of the Mac build. These files will soon only
be excluded from the Android build.

BUG=314190
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245131

[ccameron, 2014-01-15 06:26:22]

The next (big) step after this will be to separate out the
RWHVAura-ui::Compositor interface into something to be shared with Mac.

It looks to me that Android would be able to get more stuff for free if it would
use ui::Compositor and ui::Layer, but there was mixed-at-best enthusiasm for
that idea.

[danakj, 2014-01-15 17:05:32]

On 2014/01/15 06:26:22, ccameron1 wrote:
> The next (big) step after this will be to separate out the
> RWHVAura-ui::Compositor interface into something to be shared with Mac.
> 
> It looks to me that Android would be able to get more stuff for free if it
would
> use ui::Compositor and ui::Layer, but there was mixed-at-best enthusiasm for
> that idea.

Yeh, I think they would as well. There'd probably be some large work/thinking to
be done about ui::Layer to do that.

LGTM but could you update WATCHLISTS that point at c/b/aura to point at
c/b/compositor at the same time?

It looks like just the compositor resize lock is left in c/b/aura now, I wonder
if that makes sense or it should live somewhere else. I'm not sure maybe piman@
has thoughts.

[ccameron, 2014-01-15 18:09:53]

Thanks! Updated the WATCHLISTS (and the build breaks on the bots -- Mac bots
will still be broken by this until https://codereview.chromium.org/138423003/
lands).

Yeah, c/b/aura seems like a lonely place ... it may be that there's a better
home for the resizer lock (maybe just merged into RWHVAura's files, since it's a
small one).

[danakj1, 2014-01-15 18:13:40]

On Wed, Jan 15, 2014 at 1:09 PM, <ccameron@chromium.org> wrote:

> Thanks! Updated the WATCHLISTS (and the build breaks on the bots -- Mac
> bots
>

Thanks :)


> will still be broken by this until https://codereview.chromium.
> org/138423003/
> lands).
>
> Yeah, c/b/aura seems like a lonely place ... it may be that there's a
> better
> home for the resizer lock (maybe just merged into RWHVAura's files, since
> it's a
> small one).
>

I would like to continue breaking code out of
render_widget_host_view_aura.cc instead of go backward (this code used to
be in there). So I'd expect over time to have more small things like this
pulled out of RWHVA instead of the other way around.


>
> https://codereview.chromium.org/137893007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-15 21:45:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/137893007/130001

[piman, 2014-01-15 21:56:45]

On 2014/01/15 18:09:53, ccameron1 wrote:
> Thanks! Updated the WATCHLISTS (and the build breaks on the bots -- Mac bots
> will still be broken by this until https://codereview.chromium.org/138423003/
> lands).
> 
> Yeah, c/b/aura seems like a lonely place ... it may be that there's a better
> home for the resizer lock (maybe just merged into RWHVAura's files, since it's
a
> small one).

Maybe back to c/b/renderer_host, after suffixing with _aura or something.
Or, I suppose it could go to ui/aura after a minor fix (the only thing it needs
from content/ is BrowserThread, but we can just use MessageLoop::current() ).

[commit-bot: I haz the power, 2014-01-15 22:47:13]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[ccameron, 2014-01-15 23:37:31]

On 2014/01/15 21:56:45, piman wrote:
> On 2014/01/15 18:09:53, ccameron1 wrote:
> > Thanks! Updated the WATCHLISTS (and the build breaks on the bots -- Mac bots
> > will still be broken by this until
https://codereview.chromium.org/138423003/
> > lands).
> > 
> > Yeah, c/b/aura seems like a lonely place ... it may be that there's a better
> > home for the resizer lock (maybe just merged into RWHVAura's files, since
it's
> a
> > small one).
> 
> Maybe back to c/b/renderer_host, after suffixing with _aura or something.

I went with this one, so that it's next to its only consumer (RWHVAura). It may
be that there will be a compositor_resize_lock_mac that I add next door.

And d'oh, looks like the tryjob didn't pick up the updated handle types, and I
need a content/ OWNER.

[piman, 2014-01-15 23:42:23]

lgtm

[commit-bot: I haz the power, 2014-01-16 02:11:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/137893007/420001

[commit-bot: I haz the power, 2014-01-16 05:13:07]

Change committed as 245131